[Python-modules-commits] [twisted] 12/16: sort-option-keys

[Free Ekanayaka]

This is an automated email from the git hooks/post-receive script.

freee pushed a commit to branch patch-queue/master
in repository twisted.

commit 4aad2fd40f270ed3110d4f0272a252fe803444f0
Author: Free Ekanayaka <freee at debian.org>
Date:   Sat Nov 26 10:40:11 2016 +0000

    sort-option-keys
    
    Fix flaky twisted.test.test_main.MainTests.test_twisted which fails
    if options are not in the same order.
    
    See https://twistedmatrix.com/trac/attachment/ticket/8923.
    
    Gbp-Pq: Name 0008-sort-option-keys.patch
---
 src/twisted/python/usage.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/twisted/python/usage.py b/src/twisted/python/usage.py
index 4a3a972..3335583 100644
--- a/src/twisted/python/usage.py
+++ b/src/twisted/python/usage.py
@@ -388,7 +388,7 @@ class Options(dict):
         dct = {}
         reflect.addMethodNamesToDict(self.__class__, dct, "opt_")
 
-        for name in dct.keys():
+        for name in sorted(dct.keys()):
             method = getattr(self, 'opt_'+name)
 
             takesArg = not flagFunction(method, name)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/python-modules/packages/twisted.git