[Python-modules-commits] [python-asyncssh] 04/08: d/patches: remove test crashing SSH agent

Vincent Bernat bernat at moszumanska.debian.org
Wed Nov 22 21:11:48 UTC 2017


This is an automated email from the git hooks/post-receive script.

bernat pushed a commit to annotated tag debian/1.11.1-1
in repository python-asyncssh.

commit dc0ff9d08fd05490799fd9f82da5065100f44953
Author: Vincent Bernat <vincent at bernat.im>
Date:   Sun Nov 12 14:44:14 2017 +0100

    d/patches: remove test crashing SSH agent
---
 debian/changelog                                   |  4 ++--
 ...pawning-an-SSH-agent-when-previous-socket.patch | 21 ---------------------
 .../0004-remove-test-checking-unknown-keys.patch   | 22 ++++++++++++++++++++++
 debian/patches/series                              |  2 +-
 4 files changed, 25 insertions(+), 24 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 9e38616..a15298f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,7 +1,7 @@
-python-asyncssh (1.11.0-2) UNRELEASED; urgency=medium
+python-asyncssh (1.11.0-2) unstable; urgency=medium
 
   * d/patches: remove tests using deprecated ciphers. Closes: #881096.
-  * d/patches: fix tests using SSH agent. Closes: #881096.
+  * d/patches: remove test crashing SSH agent. Closes: #881096.
 
  -- Vincent Bernat <bernat at debian.org>  Sat, 11 Nov 2017 21:23:44 +0100
 
diff --git a/debian/patches/0004-fix-tests-spawning-an-SSH-agent-when-previous-socket.patch b/debian/patches/0004-fix-tests-spawning-an-SSH-agent-when-previous-socket.patch
deleted file mode 100644
index 1655e6e..0000000
--- a/debian/patches/0004-fix-tests-spawning-an-SSH-agent-when-previous-socket.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-From: Vincent Bernat <vincent at bernat.im>
-Date: Sat, 11 Nov 2017 21:47:06 +0100
-Subject: fix tests spawning an SSH agent when previous socket still here
-
----
- tests/test_agent.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/tests/test_agent.py b/tests/test_agent.py
-index 966d839..5ee1226 100644
---- a/tests/test_agent.py
-+++ b/tests/test_agent.py
-@@ -109,7 +109,7 @@ class _TestAPI(AsyncTestCase):
-         os.environ['SSH_ASKPASS'] = os.path.join(os.getcwd(), 'ssh-askpass')
- 
-         try:
--            output = run('ssh-agent -a agent 2>/dev/null')
-+            output = run('rm -f agent; ssh-agent -a agent 2>/tmp/test66')
-         except subprocess.CalledProcessError: # pragma: no cover
-             raise unittest.SkipTest('ssh-agent not available')
- 
diff --git a/debian/patches/0004-remove-test-checking-unknown-keys.patch b/debian/patches/0004-remove-test-checking-unknown-keys.patch
new file mode 100644
index 0000000..ed54718
--- /dev/null
+++ b/debian/patches/0004-remove-test-checking-unknown-keys.patch
@@ -0,0 +1,22 @@
+From: Vincent Bernat <vincent at bernat.im>
+Date: Sat, 11 Nov 2017 21:47:06 +0100
+Subject: remove test checking unknown keys
+
+This test may crash ssh-agent. Reason of why this wasn't the case
+before is unknown.
+---
+ tests/test_agent.py | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/test_agent.py b/tests/test_agent.py
+index 966d839..c06e51b 100644
+--- a/tests/test_agent.py
++++ b/tests/test_agent.py
+@@ -344,6 +344,7 @@ class _TestAPI(AsyncTestCase):
+         agent.close()
+         yield from mock_agent.stop()
+ 
++    @unittest.skip("test may crash ssh-agent")
+     @agent_test
+     def test_unknown_key(self, agent):
+         """Test failure when signing with an unknown key"""
diff --git a/debian/patches/series b/debian/patches/series
index d126cd2..85b32db 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,4 +1,4 @@
 sphinx-use-default-theme.patch
 0002-skip-tests-requiring-network-access.patch
 0003-remove-tests-using-deprecated-ciphers.patch
-0004-fix-tests-spawning-an-SSH-agent-when-previous-socket.patch
+0004-remove-test-checking-unknown-keys.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/python-modules/packages/python-asyncssh.git



More information about the Python-modules-commits mailing list