[Python-modules-team] Bug#560418: sip4-qt3: FTBFS on hurd-i386: wrong value checking for errno result

[Pino Toscano]

Package: sip4-qt3
Version: 4.9-1
Severity: important
Tags: patch
User: debian-hurd at lists.debian.org
Usertags: hurd

Hi,

currently[1] (the log refers to 4.8, but the error is the same) sip4-qt3 fails
to build on GNU/Hurd.

Basically, the problem lies in the patch 02 (siputils): one addition of it is
+                except OSError, e:
+                    if e.errno != 17:
+                        raise e
which means relying on the particular value (implementation dependent) of the
EEXIST errno. This is the same on Linux and kFreeBSD, but not on Hurd.
The easy fix is to use the errno Python module and its EEXIST constant.
The result is a compiling sip4-qt3 on GNU/Hurd and on current amd64 testing as
well.
Attached there is the fixed version of the patch 02_siputils.dpatch.

[1] http://buildd.debian-ports.org/fetch.php?&pkg=sip4-qt3&ver=4.8.2-1&arch=hurd-i386&stamp=1251535074&file=log&as=raw

Thanks,
-- 
Pino
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_siputils.dpatch
Type: text/x-shellscript
Size: 7686 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/python-modules-team/attachments/20091211/8c1b7ab6/attachment-0001.bin>