[Python-modules-team] Bug#581723: python-django-registration: tests fail whith custom registration form

[Raphael Hertzog]

Control: forwarded -1 james at b-list.org
Control: tag -1 - patch

Hi Ihor and James,

James, I would like to point you to http://bugs.debian.org/581723
It's a report from Ihor Kaharlichenko about django-registration:

On Sat, 15 May 2010, Ihor Kaharlichenko wrote:
> Automatic tests fail whenever custom registration form
> uses extra fields failing validation (i.e. captcha).
> 
> To reproduce the bug extract the test_fix.tar.gz attachement,
> and run cd test_fix/ && python manage.py test
> 
> The patch attached below isolates the URLconf used
> by tests provided with django-registration
> (see http://docs.djangoproject.com/en/1.1/topics/testing/#urlconf-configuration
> for details).

I'm not really well qualified to judge your patch. Thus I'm ccing
the upstream author who can decide to deal with it or not. In any case,
the issue seems minor enough to not warrant patching this in Debian
only.

James, is there an issue tracker where this can be filed?

> From: Ihor Kaharlichenko <cesar at mifprojects.com>
> Subject: [PATCH] fix/test_failures
> 
> Automatic tests fail whenever custom registration form
> uses extra fields failing validation (i.e. captcha).
> Force builtin URLconf to ensure default form is used in test.
> 
> Signed-off-by: Ihor Kaharlichenko <cesar at mifprojects.com>
> 
> ---
>  registration/tests.py |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/registration/tests.py b/registration/tests.py
> index 098a286..7c49855 100644
> --- a/registration/tests.py
> +++ b/registration/tests.py
> @@ -265,6 +265,9 @@ class RegistrationViewTests(RegistrationTestCase):
>      Tests for the views included in django-registration.
>      
>      """
> +
> +    urls = 'registration.urls'
> +
>      def test_registration_view(self):
>          """
>          Test that the registration view rejects invalid submissions,
> -- 
> tg: (1f03a3a..) fix/test_failures (depends on: fix/sha_warning)

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/