[Python-modules-team] Bug#694336: python-gdata: sourceless Windows binaries

[Dmitry Shachnev]

On Mon, Nov 26, 2012 at 12:02 AM, Jakub Wilk <jwilk at debian.org> wrote:
> Some minor issues with what's currently committed to svn:
>
>> +  * Remove Cipher directory from upstream tarball (closes: #694336,
>
>
> This is not quite accurate. Not the whole Cipher directory was removed, and
> some files outside this directories were removed.
>
>> +DEB_DIRECTORY := $(dir $(firstword $(MAKEFILE_LIST)))
>> +DEB_VERSION := $(word 2,$(shell cd $(DEB_DIRECTORY)/.. &&
>> dpkg-parsechangelog | grep ^Version:))
>> +UPSTREAM_DFSG_VERSION := $(firstword $(subst -, ,$(DEB_VERSION)))
>
>
> I'd recommend using "=" instead of ":=" here. Otherwise they will be
> needlessly evaluated (multiple times, thanks to how dh works) even when
> they're not used.
>
>> +get-orig-source:
>> +       sh $(dir $(firstword $(MAKEFILE_LIST)))/get-orig-source.sh
>> $(UPSTREAM_DFSG_VERSION)
>
>
> Here you could use DEB_DIRECTORY, which you defined earlier.

Fixed, thanks for your comments!

I've also uploaded the package to mentors.debian.net (which fixes this
bug and #694289):

http://mentors.debian.net/package/python-gdata
http://mentors.debian.net/debian/pool/main/p/python-gdata/python-gdata_2.0.17+dfsg-1.dsc

I am no longer able to upload it myself, so sponsoring will be welcomed.

--
Dmitry Shachnev