[Python-modules-team] Bug#718900: python3-numpy: .so files missing on kFreeBSD

[Ansgar Burchardt]

Control: clone -1 -2 -3
Control: retitle -2 python-numpy: ignores test failures
Control: severity -2 important
Control: retitle -3 python-numpy: fails to build twice in a row
Control: severity -3 important

Ansgar Burchardt <ansgar at debian.org> writes:
> "Aaron M. Ucko" <ucko at debian.org> writes:
>> The kFreeBSD python3-numpy packages somehow lack .so files, making
>> them unusable and causing matplotlib to FTBFS:
>
> As this came up on #-mentors just now:
>
> I suspect the problem is the following line in d/rules:
>
>     rm debian/python3-numpy/usr/lib/python3*/*-packages/*/*/*.cpython-*d*.so
>
> This probably should match *.cpython-3?d*, but also matches
> *.cpython-33m-* on kfreebsd as the operating system name is included
> later (which includes a "d" in the case of kfreebsd).

The patch below makes a few more files appear in python3-numpy:

+---
| Files in second .deb but not in first
| -------------------------------------
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/core/_dotblas.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/core/_dummy.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/core/multiarray.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/core/multiarray_tests.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/core/scalarmath.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/core/umath.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/core/umath_tests.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/fft/fftpack_lite.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/lib/_compiled_base.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/linalg/lapack_lite.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/numarray/_capi.cpython-33m-x86_64-kfreebsd-gnu.so
| -rw-r--r--  root/root   /usr/lib/python3/dist-packages/numpy/random/mtrand.cpython-33m-x86_64-kfreebsd-gnu.so
+---

However the tests still fail:

+---
| Traceback (most recent call last):
| [...]
| OSError: /home/ansgar/python-numpy-1.7.1/debian/tmp/usr/lib/python3/dist-packages/numpy/core/multiarray.so: cannot open shared object file: No such file or directory
| [...]
| FAILED (KNOWNFAIL=6, SKIP=5, errors=1)
+---

These failures are also not caught by d/rules:

        -set -e; for v in $(PY3VERS) ; do \

and the leading "-" tells make to ignore errors[1]. But just removing
them is not enough; I guess the tests still return 0 on failure.

  [1] <http://www.gnu.org/software/make/manual/html_node/Errors.html#Errors>

Also the package fails to build twice in a row which is a bit
annoying. dpkg complains about

  doc/source/fontList.cache
  doc/source/reference/generated/*

These files should probably be removed by the clean target.

Ansgar

--- python-numpy-1.7.1/debian/rules     2013-06-09 22:10:44.000000000 +0000
+++ python-numpy-1.7.1/debian/rules     2013-08-27 22:16:31.000000000 +0000
@@ -117,7 +117,7 @@
        dh_strip -ppython-numpy --dbg-package=python-numpy-dbg
        dh_strip -ppython3-numpy --dbg-package=python3-numpy-dbg
        # dh_strip seemingly doesn't catch the PEP 3149-style debug names
-       rm debian/python3-numpy/usr/lib/python3*/*-packages/*/*/*.cpython-*d*.so
+       rm debian/python3-numpy/usr/lib/python3*/*-packages/*/*/*.cpython-3?d*.so
 
        # fix python-debug-in-wrong-location lintian warning
        cd debian/python-numpy-dbg/usr/lib/debug/usr/lib && mv pyshared pymodules