[Python-modules-team] Bug#697348: Patch to correct this bug

[Scott Kitterman]

On Saturday, August 31, 2013 16:25:16 Jerome Kieffer wrote:
> Dear Debian Python Modules Team,
> 
> Could you please have python-qt4 recompiled for Debian6-Squeeze including
> this patch to fix bug #697348.

Are you sure that's right?  That code in the Wheezy  version of python-qt4 is:

            if bg_i18n is not None:
                # This should be handled properly in case the problem arises
                # elsewhere as well.
                try:
                    # We are compiling the .ui file.
                    bg_name = bg_i18n.string
                except AttributeError:
                    # We are loading the .ui file.
                    bg_name = bg_i18n

Your patch is a bit different:

             if bg_i18n is not None:
-                bg_name = bg_i18n.string
+                try:
+                    bg_name = bg_i18n.string
+                except AttributeError:
+                    bg_name = str(bg_i18n)

I don't know that the extra str() matters, but I think it's better to match 
upstream's change unless there's a good reason not to.  Could you please check 
that it works for you without the str()?

Scott K
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/python-modules-team/attachments/20130831/5b4d5957/attachment-0001.sig>