[Python-modules-team] Comments regarding pyqt5_5.0-1_i386.changes

[Dmitry Shachnev]

Hi Paul, and thanks for your review.

On Tue, Jul 30, 2013 at 7:45 AM, Paul Richards Tagliamonte
<ftpmaster at ftp-master.debian.org> wrote:
> Howdy, Maintainer,
>
> Can you please verify:
>
>   PyQt-gpl-5.0\examples\we~cybrowser\jquery.min.js

If I remember correctly, it's OK to ship jquery.min.js in *source*
packages (i.e. qt4-x11 has the same example written in C++ in the
tarball). In binary packages, we replace it with a symlink to a
version from libjs-jquery package.

>   PyQt-gpl-5.0\examples\xm~rns\schema\schema_rc.py
>   PyQt-gpl-5.0\examples\wi~tooltips\tooltips_rc.py
>   PyQt-gpl-5.0\examples\wi~esheet\stylesheet_rc.py
>   PyQt-gpl-5.0\examples\we~eviewer\ui_previewer.py
>   PyQt-gpl-5.0\examples\we~tor\formextractor_rc.py
>   PyQt-gpl-5.0\examples\we~ncybrowser\jquery_rc.py
>   PyQt-gpl-5.0\examples\we~mtraversal\ui_window.py
>   PyQt-gpl-5.0\examples\tools\i18n\i18n_rc.py
>   PyQt-gpl-5.0\examples\to~r\customcompleter_rc.py
>   PyQt-gpl-5.0\examples\ri~textedit\textedit_rc.py
>   PyQt-gpl-5.0\examples\qtdemo\qtdemo_rc.py
>   PyQt-gpl-5.0\examples\pa~gviewer\svgviewer_rc.py
>   PyQt-gpl-5.0\examples\pa~wing\basicdrawing_rc.py
>   PyQt-gpl-5.0\examples\op~textures\textures_rc.py
>   PyQt-gpl-5.0\examples\mainwindows\sdi\sdi_rc.py
>   PyQt-gpl-5.0\examples\mainwindows\mdi\mdi_rc.py
>   PyQt-gpl-5.0\examples\ma~dgets\dockwidgets_rc.py
>   PyQt-gpl-5.0\examples\ma~ation\application_rc.py
>   PyQt-gpl-5.0\examples\it~sheet\spreadsheet_rc.py
>   PyQt-gpl-5.0\examples\it~l\simpletreemodel_rc.py
>   PyQt-gpl-5.0\examples\it~ews\puzzle\puzzle_rc.py
>   PyQt-gpl-5.0\examples\it~xelator\pixelator_rc.py
>   PyQt-gpl-5.0\examples\it~emodel\ui_mainwindow.py
>   PyQt-gpl-5.0\examples\it~editabletreemodel_rc.py
>
>   (and the rest of the _rc.py files)
>
>
> has source attached? a quick reply showing what's creating these in the source
> tree would be nice!

These were generated from .qrc files (i.e.
examples/xmlpatterns/schema/schema.qrc) using pyrcc5 tool (source for
which is also included).

> Also, the d/copyright is out of date. Huge amounts of code is GPL-3 only,
> it'd be nice to fix this in future revisions. I also notice some LGPL 2.1,
> going through the source again would be nice :)

Should be fixed in SVN now.

It will be of course a good idea to port the copyright to DEP-5, but
that will require all previous packaging contributors to confirm their
license, which is not something I want to do now.

--
Dmitry Shachnev