[Python-modules-team] [Python-modules-commits] r24400 - in packages/pyparsing/trunk/debian (5 files)

[Thomas Goirand]

Hi,

Thanks Jakub for having a look.

On 05/16/2013 05:38 PM, Jakub Wilk wrote:
>> -    find $(CURDIR)/debian/python{,3}-pyparsing \
>> -        \( -name '*.html' -o -name '*.css' -o -name '*.py' \
>> -                          -o -name 'README' \) \
>> -        -type f -print0 \
>> -    | xargs -0 --no-run-if-empty fromdos -p --
> 
> Was dropping this intentional? The change is not documented in the
> changelog, and tofrodos is still in Build-Depends-Indep (even though
> it's no longer used AFAICS).

I just spent some time to search for DOS files, and didn't. Did you spot
some in pyparsion 1.5.7? I'm really not sure now... Was the removal of
this a mistake? I think we have time to fix it (eg: I'm waiting for
python3-pyparsing to be approved in NEW anyway...).

> OTOH the original code didn't work anyway if /bin/sh was dash:
> 
> find:
> `/build/pyparsing-gronMK/pyparsing-1.5.6+dfsg1/debian/python{,3}-pyparsing':
> No such file or directory

Yeah, {,3} is a bashism. Anyway, since 1.5.7 is python2.x only, the {,3}
part of the find call has to go anyway.

>> +    for i in `pyversions -s` ; do \
>> +        $$i setup.py install --install-layout=deb \
>> +        --root=$(CURDIR)/debian/python-pyparsing ; \
>> +    done
> 
> "set -e" is missing here (see Policy §4.6).

Thanks, this was forgotten indeed.

Thomas