[Python-modules-team] Bug#774064: podnapisi provider fails if there's no result

[Piotr Ożarowski]

Package: subliminal
Version: 0.7.4-1
Severity: minor
File: /usr/bin/subliminal

| ERROR: Unexpected error in provider 'podnapisi'
| Traceback (most recent call last):
|   File "/usr/lib/python3/dist-packages/subliminal/api.py", line 216, in download_best_subtitles
|     provider_subtitles = provider.list_subtitles(video, provider_video_languages)
|   File "/usr/lib/python3/dist-packages/subliminal/providers/podnapisi.py", line 141, in list_subtitles
|     return [s for l in languages for s in self.query(l, series=video.series, season=video.season,
|   File "/usr/lib/python3/dist-packages/subliminal/providers/podnapisi.py", line 142, in <listcomp>
|     episode=video.episode)]
|   File "/usr/lib/python3/dist-packages/subliminal/providers/podnapisi.py", line 128, in query
|     for s in root.findall('subtitle')])
|   File "/usr/lib/python3/dist-packages/subliminal/providers/podnapisi.py", line 128, in <listcomp>
|     for s in root.findall('subtitle')])
| AttributeError: 'NoneType' object has no attribute 'split'

File name I used: 'X-Files S08E09 - Salvage.mkv', language: pl


changing subliminal/providers/podnapisi.py:125's (and probably 130's):

  s.find('release').text.split()

into

  (s.find('release').text or '').split()

is a quick fix which leads to:

| ERROR: Unexpected error in provider 'podnapisi'
| Traceback (most recent call last):
|   File "/usr/lib/python3/dist-packages/subliminal/api.py", line 250, in download_best_subtitles
|     subtitle_text = provider.download_subtitle(subtitle)
|   File "/usr/lib/python3/dist-packages/subliminal/providers/podnapisi.py", line 150, in download_subtitle
|     raise ProviderError('Cannot find the download link')
| subliminal.exceptions.ProviderError: Cannot find the download link

so I guess line 121 (the one with break condition) should be improved


-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.18.0-trunk-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages subliminal depends on:
ii  python3             3.4.2-2
ii  python3-subliminal  0.7.4-1

subliminal recommends no packages.

subliminal suggests no packages.

-- no debconf information