[Python-modules-team] Bug#750715: ipython: FTBFS against uglify 2.x series - uglifyjs -nc is not a supported option

[Leo Iannacone]

On 9 June 2014 16:29, Julian Taylor <jtaylor.debian at googlemail.com> wrote:
> tags 750715 + help
> thanks
>
> As far as I understand uglify 1 and 2 are two different projects.
> Why must the version 2 package replace the version 1 pakage?
> that is not a viable strategy for hard to test javascript code.
> It seems to me it would be simpler to just have two packages.

>From the homepage of UglifyJS (https://github.com/mishoo/UglifyJS):
"""
I started working on UglifyJS's successor, version 2. It's almost a
full rewrite (except for the parser which is heavily modified,
everything else starts from scratch). I've detailed my reasons in the
README, see the project page.

https://github.com/mishoo/UglifyJS2

Version 1 will continue to be maintained for fixing show-stopper bugs,
but no new features should be expected.
"""

They share the same namespace so installing both at same time would
raise a package conflict.

In my point of view, and according with manapage, it should be better
go head with v2 and have as more as possible packages compatible with
this version.

As you can see, we have very few packages, at the moment, not
compatible with uglifyjs2:

 https://wiki.debian.org/Javascript/Nodejs/Tasks/UglifyJS2.x


> Anyhow I don't know much about javascript so I probably need a patch.

Really easy, just remove '-nc' option while calling uglifyjs in
debian/patches/packaged-js.patch:

-+ uglifyjs -nc bootstrap/js/bootstrap.js > bootstrap/js/bootstrap.min.tmp.js
++ uglifyjs bootstrap/js/bootstrap.js > bootstrap/js/bootstrap.min.tmp.js

It is also compatible with uglifyjs v1, so you don't have to wait for
uglifyjs2 in unstable to apply this change.



That's all.

Cheers,

Leo.

-- 
Ubuntu Member - http://launchpad.net/~l3on
Home Page - http://leoiannacone.com
GPG Key Id - 0xD282FC25