[Python-modules-team] Bug#748903: python-tornado: FTBFS on hurd-i386

[Svante Signell]

On Thu, 2014-05-22 at 22:49 +0200, Guillem Jover wrote:
> Hi!
> 
> On Thu, 2014-05-22 at 09:20:59 +0200, Svante Signell wrote:
> > Source: python-tornado
> > Version: 3.2.0-1
> > Severity: important
> > Tags: patch
> > User: debian-hurd at lists.debian.org
> > Usertags: hurd
> 
> > Currently python-tornado fails to build from source on GNU/Hurd due to
> > two failed tests: test_unix_socket and test_unix_socket_bad_request.
> > The attached patch fixes these failures by not using the options 
> > SO_REUSEADDR for setsockopt in tornado/netutil.py and SO_ERROR for
> > getsockopt in tornado/iostream.py since they are not yet implemented.
...
> 
> I've not verified but if sock.setsockopt is mostly a wrapper on top of
> the POSIX function, then it would be way better to check if errno is
> ENOPROTOOPT, and ignore the error condition then. Which would make the
> code not GNU/Hurd specific, would also start testing those flags once
> they are implemented, and might also help any other system where those
> SO_* flags are not implemented yet.

Updated path, renamed to sockopt.patch. Test built on GNU/Hurd and
GNU/Linux. Better now?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sockopt.patch
Type: text/x-patch
Size: 1483 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/python-modules-team/attachments/20140523/95ef6118/attachment.bin>