[Python-modules-team] Bug#788505: python-pypump: [PATCH] please make the build reproducible

[W. Martin Borgert]

Dear Juan, (and H01ger, Lunar and team cc'ed),

while I'm all in favour of reproducible builds, I'm not happy
with messing up hundreds of packages debian/rules files. Why not
change the defaults of sphinx or dh or whatever and just rebuild
packages?

Who needs or wants a "last change date" in the HTML anyway?

We worked years to get the d/r files clean and short and now we
add cruft to it again? Which is repeated redundantly in hundreds of
files? Maybe dh_sphinxdoc could just "do the right thing"?

Cheers


On 2015-06-11 22:51, Juan Picca wrote:
>  [1]: https://wiki.debian.org/ReproducibleBuilds

> diff -urNp python-pypump-0.6.old/debian/rules python-pypump-0.6/debian/rules
> --- python-pypump-0.6.old/debian/rules	2015-05-13 14:48:10.000000000 -0300
> +++ python-pypump-0.6/debian/rules	2015-06-11 22:30:19.454056240 -0300
> @@ -2,6 +2,10 @@
>  PYTHONS:=$(shell pyversions -vr)
>  PYTHON3S:=$(shell py3versions -vr)
>  
> +LAST_CHANGE = $(shell dpkg-parsechangelog -S Date)
> +BUILD_DATE  = $(shell LC_ALL=C date -u "+%B %d, %Y" -d "$(LAST_CHANGE)")
> +SPHINXOPTS := -D today=\"$(BUILD_DATE)\"
> +
>  %:
>  	dh $@ --buildsystem=python_distutils --with python2,python3,sphinxdoc
>  
> @@ -12,7 +16,7 @@ override_dh_clean:
>  
>  override_dh_auto_build:
>  	dh_auto_build
> -	make -C docs html
> +	make -C docs html SPHINXOPTS="$(SPHINXOPTS)"
>  
>  	# # This version pypump-shell needs the path $HOME/.config/
>  	# # to exist for it to build correctly, so I'm adding it