[Python-modules-team] Bug#806761: python-botocore: requests.packages.urllib3.exceptions should be urllib3.exceptions

[Geoffrey Thomas]

Package: python-botocore
Version: 1.3.9-1
Severity: wishlist

Hi maintainer,

In the "Don't use duplicated modules" patch, in
botocore/retryhandler.py,
botocore.vendored.requests.packages.urllib3.exceptions becomes
requests.packages.urllib3.exceptions. But actually it should be just
urllib3.exceptions, matching all the other imports from
botocore.vendored.requests.packages.urllib3 from that patch.

When running against python-requests from jessie (I'm trying to build
botocore and boto3 for jessie-backports), that import doesn't actually
work; see bug #771349 for a similar issue. In Stretch, python-requests
(>= 2.7.0-3) has better devendorization logic that fixes that bug. So
I've marked this wishlist since I don't actually think it affects
Stretch. But it's still inconsistent.

I suppose the same change should also be made to the diff to
tests/unit/test_awsrequest.py in the "Don't use duplicated modules (in
tests)" patch.

Thanks,
-- 
Geoffrey Thomas
geofft at hudson-trading.com