[Python-modules-team] Bug#859504: python-requests breaks packages using urllib3

[Daniele Tricoli]

forwarded 859504 https://github.com/kennethreitz/requests/issues/2870
thanks

Hello Ilias,
thanks for your patch!

On Tuesday, April 4, 2017 4:17:54 PM CEST Ilias Tsitsimpis wrote:
> Package: python-requests
> Version: 2.12.4-1
> Severity: important
> Tags: patch
> 
> Hello,
> 
> thank you for maintaining python-requests.
> 
> It seems that patch use-pip-unbundling.patch doen not work as expected:
>     >>> import sys, urllib3
>     >>> from urllib3.exceptions import HTTPError
>     >>> urllib3.exceptions.HTTPError is HTTPError
> 
>     True
> 
>     >>> sys.modules["urllib3.exceptions"] is urllib3.exceptions
> 
>     True
> 
>     >>> import requests
>     >>> urllib3.exceptions.HTTPError is HTTPError
> 
>     False
> 
>     >>> sys.modules["urllib3.exceptions"] is urllib3.exceptions
> 
>     False
> 
> This causes (otherwise correct) Python programs to fail by simply
> importing the 'requests' module. The solution proposed by upstream[1]
> doesn't work either.
> 
> [1]
> https://github.com/kennethreitz/requests/blob/master/requests/packages/__in
> it__.py
> 
> Attached is a patch that works for me and seems to fix the above bug.
> It would be great if this could be fixed for stretch.

Yes, unfortunately the unbundling logic is still breaking stuffs. The issue 
was discussed here: https://github.com/kennethreitz/requests/issues/2870 you 
will find a detailed explanation on this issue. 

I looked quickly at your patch (I will have more time to spend on it during 
the weekend), but before any change on Debian side, I want to discuss with 
upstream. The unbundling stuff bit already us in past so I'm very cautious.

Please can you restart the discussion on upstream bug tracker? Thanks!

-- 
 Daniele Tricoli 'eriol'
 https://mornie.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/python-modules-team/attachments/20170405/3f405761/attachment-0001.sig>