[Python-modules-team] Bug#872285: pyqt5-dev-tools: please make the built resources reproducible (randomness)

[Federico Brega]

Package: pyqt5-dev-tools
Version: 5.7+dfsg-5+b1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness

Hello.

I noticed that the python files generated by pyrcc5 are not reproducible.

I attached a patch to set the seed of QHash, which is used by the cpp part of pyrcc. This removes the randomness out of QHash, so generating the same resource file twice gives identical files.
-------------- next part --------------
Description: Make the build reproducible
Author: Federico Brega <charon.66 at gmail.com>
Last-Update: 2017-08-15

--- a/qpy/pyrcc/rcc.h
+++ b/qpy/pyrcc/rcc.h
@@ -124,6 +124,7 @@
     mCompressLevel = -1;
     mCompressThreshold = 70;
     mTreeOffset = mNamesOffset = mDataOffset = 0;
+    qSetGlobalQHashSeed(0);
 }
 
 struct RCCFileInfo