[Python-modules-team] Bug#871156: pyfits: FTBFS: cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]

[Steve Langasek]

Package: pyfits
Version: 1:3.4-4
Followup-For: Bug #871156
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch

Hi Aurelien,

Attached is a simple fix for this build failure which I've uploaded to
Ubuntu.  There is no reason for this build system to explicitly disable
-Wformat on Debian, the code builds fine as-is.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru pyfits-3.4/debian/patches/series pyfits-3.4/debian/patches/series
--- pyfits-3.4/debian/patches/series	2016-12-19 15:41:17.000000000 -0800
+++ pyfits-3.4/debian/patches/series	2017-08-27 22:40:43.000000000 -0700
@@ -2,3 +2,4 @@
 02-numpy-deprecation-warning.diff
 03-fix-for-cfitsio-3380.patch
 04-numpy-1.12.patch
+yes-Wformat.patch
diff -Nru pyfits-3.4/debian/patches/yes-Wformat.patch pyfits-3.4/debian/patches/yes-Wformat.patch
--- pyfits-3.4/debian/patches/yes-Wformat.patch	1969-12-31 16:00:00.000000000 -0800
+++ pyfits-3.4/debian/patches/yes-Wformat.patch	2017-08-27 22:43:35.000000000 -0700
@@ -0,0 +1,21 @@
+Description: don't disable format warnings, which breaks -Werror=format-security
+ By default we use hardening flags for package builds to detect certain common
+ security errors, but -Werror=format-security was being silently ignored
+ because of upstream's use of -Wformat.  GCC7 now detects this conflict and
+ requires manual resolution, which we resolve in favor of enforcing the
+ security check.
+Author: Steve Langasek <steve.langasek at ubuntu.com>
+Bug-Debian: https://bugs.debian.org/871156
+
+Index: pyfits-3.4/setup.cfg
+===================================================================
+--- pyfits-3.4.orig/setup.cfg
++++ pyfits-3.4/setup.cfg
+@@ -120,7 +120,6 @@
+ 	-Wno-unused-variable
+ 	-Wno-parentheses
+ 	-Wno-uninitialized
+-	-Wno-format
+ 	-Wno-strict-prototypes
+ 	-Wno-unused
+ 	-Wno-comments