[Python-modules-team] Bug#850537: foolscap: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:foolscap
Version: 0.12.5-1
Severity: important

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with python2 --buildsystem=python_distutils
   dh_testdir -i -O--buildsystem=python_distutils
   dh_update_autotools_config -i -O--buildsystem=python_distutils
   dh_auto_configure -i -O--buildsystem=python_distutils
   dh_auto_build -i -O--buildsystem=python_distutils
	python setup.py build --force
running build
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/foolscap
copying src/foolscap/furl.py -> build/lib.linux-x86_64-2.7/foolscap
copying src/foolscap/info.py -> build/lib.linux-x86_64-2.7/foolscap

[... snipped ...]

new-style classes still broken

foolscap.test.test_banana.ThereAndBackAgain.test_boundMethod_newstyle
foolscap.test.test_banana.ThereAndBackAgain.test_classMethod_newstyle
foolscap.test.test_banana.ThereAndBackAgain.test_class_newstyle
foolscap.test.test_banana.ThereAndBackAgain.test_instance_newstyle
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/debian/python-foolscap/usr/lib/python2.7/dist-packages/foolscap/test/test_negotiate.py", line 387, in checkConnectedViaReverse
    self.failUnlessEqual(self.tub2phases, targetPhases)
  File "/usr/lib/python2.7/dist-packages/twisted/trial/_synctest.py", line 425, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 742, in assertListEqual
    self.assertSequenceEqual(list1, list2, msg, seq_type=list)
  File "/usr/lib/python2.7/unittest/case.py", line 724, in assertSequenceEqual
    self.fail(msg)
twisted.trial.unittest.FailTest: Lists differ: [] != [1]

Second list contains 1 additional elements.
First extra element 0:
1

- []
+ [1]
?  +


foolscap.test.test_negotiate.CrossfireReverse.test4
-------------------------------------------------------------------------------
Ran 524 tests in 100.210s

FAILED (skips=4, failures=1, successes=519)
Makefile:12: recipe for target 'test' failed
make[2]: *** [test] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: make -j1 test returned exit code 2
debian/rules:12: recipe for target 'override_dh_auto_install' failed
make[1]: *** [override_dh_auto_install] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:6: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

This is just how the build ends, not necessarily the relevant part.

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/foolscap/

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

The bug should be reproducible with sbuild on a single CPU virtual machine,
provided you try enough times (as the failure happens randomly).

Thanks.