[Python-modules-team] Bug#883056: python-django-debug-toolbar: fix missing test dep on django-jinja

[Steve Langasek]

Package: python-django-debug-toolbar
Version: 1:1.8-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

Hi Andrew,

Since python-django-debug-toolbar was updated to 1:1.8-1, the autopkgtests
have been failing continuously due to a missing test dep on python-django-jinja:

autopkgtest [18:40:03]: test testsuite: [-----------------------
Traceback (most recent call last):
  File "/usr/bin/django-admin", line 21, in <module>
    management.execute_from_command_line()
  File "/usr/lib/python3/dist-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python3/dist-packages/django/core/management/__init__.py", line 338, in execute
    django.setup()
  File "/usr/lib/python3/dist-packages/django/__init__.py", line 27, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/usr/lib/python3/dist-packages/django/apps/registry.py", line 85, in populate
    app_config = AppConfig.create(entry)
  File "/usr/lib/python3/dist-packages/django/apps/config.py", line 94, in create
    module = import_module(entry)
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'django_jinja'
autopkgtest [18:40:04]: test testsuite: -----------------------]
testsuite            FAIL non-zero exit status 1

(https://ci.debian.net/packages/p/python-django-debug-toolbar/unstable/amd64/)

Unfortunately Debian does not consider a regressed autopkgtest a blocker for
testing (which would be useful to help us improve the quality of the
release), but Ubuntu does; so this regression has blocked the new
python-django-debug-toolbar package from inclusion in Ubuntu 17.10.

I have uploaded the attached straightforward patch to Ubuntu, fixing the
test failure.  Please consider applying it in Debian as well.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru python-django-debug-toolbar-1.8/debian/tests/control python-django-debug-toolbar-1.8/debian/tests/control
--- python-django-debug-toolbar-1.8/debian/tests/control	2015-11-01 13:41:58.000000000 -0800
+++ python-django-debug-toolbar-1.8/debian/tests/control	2017-11-29 00:03:20.000000000 -0800
@@ -1,2 +1,2 @@
 Tests: testsuite
-Depends: @, python, python-django, python-sqlparse
+Depends: @, python, python-django, python-django-jinja, python3-django-jinja, python-sqlparse