[Python-modules-team] Bug#895269: vcr.py: please make the build reproducible

[Chris Lamb]

Source: vcr.py
Version: 1.11.1-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that vcr.py could not be built reproducibly. This is due to the
documentation containing the current absolute buildpath via Python
default arguments.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2018-04-09 09:07:23.797126437 +0100
@@ -0,0 +1,23 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-04-09
+
+--- vcr.py-1.11.1.orig/vcr/cassette.py
++++ vcr.py-1.11.1/vcr/cassette.py
+@@ -174,13 +174,13 @@ class Cassette(object):
+     def use(cls, **kwargs):
+         return CassetteContextDecorator.from_args(cls, **kwargs)
+ 
+-    def __init__(self, path, serializer=yamlserializer, persister=FilesystemPersister, record_mode='once',
++    def __init__(self, path, serializer=None, persister=None, record_mode='once',
+                  match_on=(uri, method), before_record_request=None,
+                  before_record_response=None, custom_patches=(),
+                  inject=False):
+-        self._persister = persister
++        self._persister = persister or FilesystemPersister
+         self._path = path
+-        self._serializer = serializer
++        self._serializer = serializer or yamlserializer
+         self._match_on = match_on
+         self._before_record_request = before_record_request or (lambda x: x)
+         self._before_record_response = before_record_response or (lambda x: x)
--- a/debian/patches/series	2018-04-09 08:37:27.191583589 +0100
--- b/debian/patches/series	2018-04-09 09:07:22.725120692 +0100
@@ -1 +1,2 @@
 remove-privacy-breach-urls.patch
+reproducible-build.patch