[Python-modules-team] Bug#917658: pyres: FTBFS (AttributeError: 'int' object has no attribute 'iteritems')

[Santiago Vila]

Package: src:pyres
Version: 1.5-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with python2,systemd --buildsystem=pybuild
   dh_update_autotools_config -i -O--buildsystem=pybuild
   dh_auto_configure -i -O--buildsystem=pybuild
I: pybuild base:217: python2.7 setup.py config 
running config
   dh_auto_build -i -O--buildsystem=pybuild
I: pybuild base:217: /usr/bin/python setup.py build 
running build
running build_py
creating /<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres
copying pyres/scripts.py -> /<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres
copying pyres/worker.py -> /<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres
copying pyres/__init__.py -> /<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres

[... snipped ...]

    def test_retry_on_exception(self):
        now = datetime.datetime.now()
        self.set_current_time(now)
        worker = Worker(['basic'])
        scheduler = Scheduler()
    
        # queue up a job that will fail for 30 seconds
        self.resq.enqueue(RetryOnExceptionJob,
                now + datetime.timedelta(seconds=30))
        worker.process()
>       assert worker.get_failed() == 0
E       AssertionError: assert 1 == 0
E        +  where 1 = <bound method Worker.get_failed of <pyres.worker.Worker object at 0x7f614aae4f10>>()
E        +    where <bound method Worker.get_failed of <pyres.worker.Worker object at 0x7f614aae4f10>> = <pyres.worker.Worker object at 0x7f614aae4f10>.get_failed

tests/test_worker.py:191: AssertionError
------------------------------ Captured log call -------------------------------
worker.py                  273 ERROR    (Job{basic} | tests.RetryOnExceptionJob | [datetime.datetime(2018, 12, 25, 22, 42, 17)]) failed: 'int' object has no attribute 'iteritems'
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres/worker.py", line 256, in process
    return job.perform()
  File "/<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres/job.py", line 88, in perform
    if not self.retry(payload_class, args):
  File "/<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres/job.py", line 126, in retry
    **{'first_attempt':first_attempt})
  File "/<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres/__init__.py", line 279, in enqueue_at
    self.enqueue_at_from_string(datetime, class_name, klass.queue, *args, **kwargs)
  File "/<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres/__init__.py", line 289, in enqueue_at_from_string
    self.delayed_push(datetime, payload)
  File "/<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build/pyres/__init__.py", line 294, in delayed_push
    self.redis.zadd('resque:delayed_queue_schedule', key, key)
  File "/usr/lib/python2.7/dist-packages/redis/client.py", line 2263, in zadd
    for pair in iteritems(mapping):
  File "/usr/lib/python2.7/dist-packages/redis/_compat.py", line 94, in iteritems
    return x.iteritems()
AttributeError: 'int' object has no attribute 'iteritems'
=============================== warnings summary ===============================
.pybuild/cpython2_2.7_pyres/build/tests/test_failure_multi.py::TestBackend
  cannot collect test class 'TestBackend' because it has a __init__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
======== 7 failed, 70 passed, 1 deselected, 1 warnings in 8.21 seconds =========
E: pybuild pybuild:338: test: plugin distutils failed with: exit code=1: cd /<<PKGBUILDDIR>>/.pybuild/cpython2_2.7_pyres/build; python2.7 -m pytest -k 'not test_worker_pids'
dh_auto_test: pybuild --test -i python{version} -p 2.7 returned exit code 13
make: *** [debian/rules:9: build-indep] Error 25
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
E: Build killed with signal TERM after 60 minutes of inactivity
--------------------------------------------------------------------------------

The build was made in my autobuilder with "dpkg-buildpackage -A"
but it also fails here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/pyres.html

where you can get a full build log if you need it (for some reason, reproducible-builds
autobuilders do not hang here).

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.