[Python-modules-team] Bug#886003: python-pysnmp4: please make the build reproducible

[Chris Lamb]

Source: python-pysnmp4
Version: 4.4.3-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that python-pysnmp4 could not be built reproducibly.

This is because the documentation contains references to non-
deterministic memory addresses.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/0002-Reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/0002-Reproducible-build.patch	2018-01-01 12:41:27.160378886 +0000
@@ -0,0 +1,17 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-01-01
+
+--- python-pysnmp4-4.4.3.orig/pysnmp/smi/rfc1902.py
++++ python-pysnmp4-4.4.3/pysnmp/smi/rfc1902.py
+@@ -695,7 +695,9 @@ class ObjectType(object):
+     """
+     stDirty, stClean = 1, 2
+ 
+-    def __init__(self, objectIdentity, objectSyntax=rfc1905.unSpecified):
++    def __init__(self, objectIdentity, objectSyntax=None):
++        if objectSyntax is None:
++            objectSyntax = rfc1905.unSpecified
+         if not isinstance(objectIdentity, ObjectIdentity):
+             raise SmiError('initializer should be ObjectIdentity instance, not %r' % (objectIdentity,))
+         self.__args = [objectIdentity, objectSyntax]
--- a/debian/patches/series	2018-01-01 12:35:36.370133172 +0000
--- b/debian/patches/series	2018-01-01 12:41:26.284373268 +0000
@@ -1 +1,2 @@
 0001-Remove-privacy-breach-badges.patch
+0002-Reproducible-build.patch