[Python-modules-team] Bug#894466: python-fisx: please make the build reproducible

[Chris Lamb]

Source: python-fisx
Version: 1.1.4-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that python-fisx could not be built reproducibly as it includes
the build path in the definition of FISX_DOC_DIR in DataDir.py:

│ │ │ ├── ./usr/lib/python2.7/dist-packages/fisx/DataDir.py
│ │ │ │ @@ -25,15 +25,15 @@
│ │ │ │  # THE SOFTWARE.
│ │ │ │  #
│ │ │ │  #############################################################################*/
│ │ │ │  import os
│ │ │ │  # this will be filled by the setup
│ │ │ │  FISX_DATA_DIR = r'/usr/share/fisx/'
│ │ │ │  # this is to be filled by the setup
│ │ │ │ -FISX_DOC_DIR = r'/build/1st/python-fisx-1.1.4/debian/python-fisx/usr/lib/python2.7/dist-packages/fisx/fisx_data'
│ │ │ │ +FISX_DOC_DIR = r'/build/python-fisx-1.1.4/2nd/debian/python-fisx/usr/lib/python2.7/dist-packages/fisx/fisx_data'


Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2018-03-30 15:56:57.061589875 +0100
--- b/debian/rules	2018-03-30 17:59:24.106202503 +0100
@@ -4,7 +4,8 @@
 export PYBUILD_VERBOSE=1
 
 export WITH_CYTHON=1
-export FISX_DATA_DIR=/usr/share/fisx/
+export FISX_DATA_DIR=/usr/share/fisx
+export FISX_DOC_DIR=/usr/share/doc/python-fisx-common
 export PKGCOMMON=$(CURDIR)/debian/python-fisx-common/
 
 export PYBUILD_NAME=fisx
@@ -27,4 +28,4 @@
 	rm -f $(PKGCOMMON)/$(FISX_DATA_DIR)/LICENSE
 
 override_dh_auto_test:
-	FISX_DATA_DIR=$(CURDIR)/fisx_data dh_auto_test
+	FISX_DATA_DIR=$(CURDIR)/fisx_data FISX_DOC_DIR=$(CURDIR)/fisx_data dh_auto_test