[Python-modules-team] Bug#897449: django-allauth: Invalid character reference 138 in "Last Translator" field in some .po files (Bug#881727 reappeared when uploading 0.35 version)

[Pierre-Elliott Bécue]

Le mercredi 02 mai 2018 à 21:20:53+0200, Laura Arjona Reina a écrit :
> Package: django-allauth
> Severity: wishlist
> Tags: patch l10n upstream
> 
> Dear Maintainer,
> 
> When uploading the 0.35 version, the bug Bug#881727 reappeared again:
> 
> Some of the upstream .po files, in the "Last translator" field, include
> a name of translator with a bad encoded character (numeric character
> reference 138 instead of Š). This produces "Tidy Validation" warning
> messages when building the Debian website pages.
> The .PO files do not include mail address for the translator with the
> bad encoding, so I've requested to join the django-allauth translation
> team in Transifex, with the hope of contacting Jannis Š and request them
> to fix the encoding in their profile in Transifex.
> 
> Meanwhile, I'm attaching a patch that uses the correct UTF-8 character.

Hi,

This is very weird.

As you can see in the salsa repository, your patch is still there, and it
applied correctly (I rebased it on the new release).

As I did the upload myself, I took the .deb package I sent to the archive,
and extracted it, and placed myself in
usr/lib/python3/dist-packages/allauth/locale and ran this:

.-(.../dependencies/django-allauth/toto/usr/lib/python3/dist-packages/allauth/locale)-
`---> cat {es,pt_PT,sv,tr}/LC_MESSAGES/django.po|grep 'Jannis'
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"

All seem fine.

As the package is also installed on my server, I also did this:

.-(13:50:00)-(~)---------------------------------------------------------(peb at pimeys)-
`---> acp python-django-allauth
python-django-allauth:
  Installé : 0.35.0-1~bpo9+3
  Candidat : 0.35.0-1~bpo9+3
 Table de version :
     0.35.0-2 99
         99 http://ftp.fr.debian.org/debian sid/main amd64 Packages
 *** 0.35.0-1~bpo9+3 100
        100 http://ftp.fr.debian.org/debian stretch-backports/main amd64 Packages
        100 /var/lib/dpkg/status
.-(13:50:04)-(~)---------------------------------------------------------(peb at pimeys)-
`---> cd /usr/lib/python2.7/dist-packages/allauth/locale/
.-(13:50:26)-(/usr/lib/python2.7/dist-packages/allauth/locale)-----------(peb at pimeys)-
`---> cat {es,pt_PT,sv,tr}/LC_MESSAGES/django.po|grep 'Jannis'
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"
"Last-Translator: Jannis Š\n"

Your patch really seems to work fine.

So, I wonder, maybe this error is triggered because the *source* actually
still contains this wrongfully encoded character? But theoretically I'm not
supposed to alter upstream's source.

Cheers,

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/python-modules-team/attachments/20180504/faba2915/attachment.sig>