[Python-modules-team] Bug#926802: ipywidgets: FTBFS (TypeError: path.scope.getBindings(...).hasOwnProperty is not a function)

[Santiago Vila]

Package: src:ipywidgets
Version: 6.0.0-3
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with python2,python3,sphinxdoc --buildsystem=pybuild
   dh_update_autotools_config -i -O--buildsystem=pybuild
   dh_autoreconf -i -O--buildsystem=pybuild
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_configure
I: pybuild base:217: python2.7 setup.py config 
running config
I: pybuild base:217: python3.7 setup.py config 
running config
dh_auto_configure -- -d ./widgetsnbextension
I: pybuild base:217: python2.7 setup.py config 
INFO:root:setup.py entered
INFO:root:$PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
running config
I: pybuild base:217: python3.7 setup.py config 
INFO:root:setup.py entered
INFO:root:$PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
running config
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make -C debian -f fakewebpack.mk all
make[2]: Entering directory '/<<PKGBUILDDIR>>/debian'
/usr/bin/make -f "fakewebpack-prep-unpacked.mk" all
make[3]: Entering directory '/<<PKGBUILDDIR>>/debian'
cd "fakewebpack-unpacked/phosphor/" && tsc --moduleResolution Classic --project src
mkdir -p "fakewebpack-unpacked/phosphor/styles/" && NODE_PATH=../.. fakewebpack-helpers/css-loader-pack.py < "fakewebpack-unpacked/phosphor/styles/base.css.real" > "fakewebpack-unpacked/phosphor/styles/base.css"
mkdir -p "fakewebpack-unpacked/phosphor/styles/" && m4 -DNODE_PATH=../.. -DCSS_INPUT=./base.css "fakewebpack-helpers/style-loader.js.m4" > "fakewebpack-unpacked/phosphor/styles/base.css?f74d"
printf "module.exports = $(cat "fakewebpack-unpacked/jupyter-js-widgets/package.json.real");" > "fakewebpack-unpacked/jupyter-js-widgets/package.json"
cd "fakewebpack-unpacked/jupyter-js-widgets/" && tsc --moduleResolution Classic --project src
mkdir -p "fakewebpack-unpacked/jupyter-js-widgets/css/"
cd ../jupyter-js-widgets/css && cat widgets.css | \
sed -e '/@import ".\/labvariables.css"/{r ./labvariables.css'"${NLD}"'}' \
    -e '/@import ".\/widgets-base.css"/{r ./widgets-base.css'"${NLD}"'}' | \
sed -e '/@import ".\/materialcolors.css"/{r ./materialcolors.css'"${NLD}"'}' > /<<PKGBUILDDIR>>/debian/"fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css.real"
mkdir -p "fakewebpack-unpacked/jupyter-js-widgets/css/" && NODE_PATH=../.. fakewebpack-helpers/css-loader-pack.py < "fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css.real" > "fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css"
mkdir -p "fakewebpack-unpacked/jupyter-js-widgets/css/" && m4 -DNODE_PATH=../.. -DCSS_INPUT=./widgets.css "fakewebpack-helpers/style-loader.js.m4" > "fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css?7dc3"
mkdir -p "fakewebpack-unpacked/widgetsnbextension/webpack/ ./" && m4 -DWEBPACK_PUBLIC_PATH= "fakewebpack-helpers/webpack-bootstrap.js.m4" > "fakewebpack-unpacked/widgetsnbextension/webpack/bootstrap e65abc6196a7e23c9fcf"
mkdir -p "fakewebpack-unpacked/widgetsnbextension/css/" && NODE_PATH=../node_modules fakewebpack-helpers/css-loader-pack.py < "fakewebpack-unpacked/widgetsnbextension/css/outputarea.css.real" > "fakewebpack-unpacked/widgetsnbextension/css/outputarea.css"
mkdir -p "fakewebpack-unpacked/widgetsnbextension/css/" && m4 -DNODE_PATH=../node_modules -DCSS_INPUT=./outputarea.css "fakewebpack-helpers/style-loader.js.m4" > "fakewebpack-unpacked/widgetsnbextension/css/outputarea.css?73c5"
printf "module.exports = $(cat "fakewebpack-unpacked/widgetsnbextension/package.json.real");" > "fakewebpack-unpacked/widgetsnbextension/package.json"
mkdir -p fakewebpack
touch "fakewebpack/prep.stamp"
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian'
touch fakewebpack/widgetsnbextension-unpacked.stamp
rm -rf "fakewebpack/widgetsnbextension" && mkdir -p "fakewebpack/widgetsnbextension" && ./fakewebpack-generate.py fakewebpack-meta/widgetsnbextension.files fakewebpack-meta/widgetsnbextension.modules fakewebpack-unpacked/widgetsnbextension/ True > "fakewebpack/widgetsnbextension/extension.js" && touch "fakewebpack/widgetsnbextension.stamp"
/<<PKGBUILDDIR>>/debian/fakewebpack-postprocess.js:130
                if (!path.scope.getBindings().hasOwnProperty(path.node.name)) {
                                              ^

TypeError: path.scope.getBindings(...).hasOwnProperty is not a function
    at Context.visitIdentifier (/<<PKGBUILDDIR>>/debian/fakewebpack-postprocess.js:130:47)
    at Context.invokeVisitorMethod (/usr/lib/nodejs/ast-types/lib/path-visitor.js:344:49)
    at Visitor.PVp.visitWithoutReset (/usr/lib/nodejs/ast-types/lib/path-visitor.js:196:32)
    at visitChildren (/usr/lib/nodejs/ast-types/lib/path-visitor.js:246:25)
    at Visitor.PVp.visitWithoutReset (/usr/lib/nodejs/ast-types/lib/path-visitor.js:204:20)
    at visitChildren (/usr/lib/nodejs/ast-types/lib/path-visitor.js:246:25)
    at Visitor.PVp.visitWithoutReset (/usr/lib/nodejs/ast-types/lib/path-visitor.js:204:20)
    at visitChildren (/usr/lib/nodejs/ast-types/lib/path-visitor.js:246:25)
    at Visitor.PVp.visitWithoutReset (/usr/lib/nodejs/ast-types/lib/path-visitor.js:204:20)
    at visitChildren (/usr/lib/nodejs/ast-types/lib/path-visitor.js:246:25)
module 00: nodejs ../../fakewebpack-postprocess.js ./src/extension.js ../../fakewebpack-meta/widgetsnbextension.modules
module 01: nodejs ../../fakewebpack-postprocess.js ./src/manager.js ../../fakewebpack-meta/widgetsnbextension.modules
module 02: nodejs ../../fakewebpack-postprocess.js ./node_modules/underscore/underscore.js ../../fakewebpack-meta/widgetsnbextension.modules
Traceback (most recent call last):
  File "./fakewebpack-generate.py", line 97, in <module>
    sys.exit(main(*sys.argv[1:]))
  File "./fakewebpack-generate.py", line 66, in main
    cwd=srcdir).decode("utf-8")
  File "/usr/lib/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.7/subprocess.py", line 487, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['nodejs', '../../fakewebpack-postprocess.js', './node_modules/underscore/underscore.js', '../../fakewebpack-meta/widgetsnbextension.modules']' returned non-zero exit status 1.
make[2]: *** [fakewebpack.mk:77: fakewebpack/widgetsnbextension.stamp] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/debian'
make[1]: *** [debian/rules:15: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:7: build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made in my autobuilder with "dpkg-buildpackage -A"
and it also fails here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ipywidgets.html

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.