[Python-modules-team] Bug#922259: python-libnacl: FTBFS (ValueError: byte must be in range(0, 256))

[Colin Watson]

Control: forwarded -1 https://github.com/saltstack/libnacl/pull/115

On Wed, Apr 03, 2019 at 11:06:24PM +0200, Santiago Vila wrote:
> > ======================================================================
> > ERROR: test_verify32 (unit.test_verify.TestVerify)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.7_libnacl/build/tests/unit/test_verify.py", line 30, in test_verify32
> >     v32x[libnacl.randombytes_random() & 31] += 1
> > ValueError: byte must be in range(0, 256)
> 
> Hi. This is still happening (randomly) on reproducible-builds.
> 
> I could offer ssh access to a machine where this randomness is
> reproducible, but I believe the randomness is intrisic to the
> (wrongly designed) test and maybe it happens on any machine
> as far as you try enough times.
> 
> Can you execute test_verify32 in a loop and report if it fails
> randomly or not for you? (Or tell me the way to do it).

Indeed, it's easy to reproduce that way.  I tracked this down and
proposed a fix upstream:

  https://github.com/saltstack/libnacl/pull/115

Thanks,

-- 
Colin Watson                                       [cjwatson at debian.org]