[Python-modules-team] Bug#917854: RFS: pygithub/1.43.3-1

[Dmitry Shachnev]

Hi Dmitry!

On Thu, Jan 03, 2019 at 04:12:53AM +0000, Dmitry Bogatov wrote:
> Looks fine, but I do not understand following line in `debian/rules':
>
>         rm -rfv debian/python3-github/usr/lib/python3.*
>
> What is removed and why same statement it is not needed for python2
> version?  Comment in `debian/rules' would be nice.

I suggested to add that line. Quoting from my mail in #900368:

"""
- When building in the current sid, I get Lintian warnings about three files
  shipped in /usr/lib/python3.7/dist-packages/.

  That probably happens because of output of 2to3 is slightly different in
  Python 3.6 and 3.7 (e.g. files.items() vs. iter(files.items())), and
  dh_python3 does not remove the file if it does not match.

  I would recommend removing debian/python3-github/usr/lib/python3.* manually
  in debian/rules.
"""

Normally files should be installed in /usr/lib/python3/dist-packages
(not .../python3.x/...). But if there are mulitple supported Python 3 versions
and some installed files differ between these versions, dh_python3 can leave
some files in /usr/lib/python3.x/dist-packages, which causes Lintian warnings
and should be avoided.

Now that Python 3.6 is no longer supported (and there is only one supported
Python 3 version), that hack can be dropped.

--
Dmitry Shachnev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/python-modules-team/attachments/20190202/de50b213/attachment.sig>