[Python-modules-team] Bug#920293: FTBFS: python-apptools auto-generated files contaminate source package

[Stewart Ferguson]

Package: python-apptools
Version: 4.3.0-1
Severity: important
Tags: ftbfs
Owner: stew at ferg.aero

When building from the Salsa git repository, this package is ftbfs.  This
is because during dh_clean, setup.py checks for .git, and if it exists, it
modifies apptools/_version.py.  This leaves a modified file in the tree
which causes dpkg-source to fail.

I've set the severity as "important" instead of "serious" because this does
not affect users who build from the dsc.

Full log below:

dpkg-buildpackage -us -uc -ui
dpkg-buildpackage: info: source package python-apptools
dpkg-buildpackage: info: source version 4.3.0-2
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by Ondřej Nový <novy at ondrej.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
pyversions: missing X(S)-Python-Version in control file, fall back to
debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
test -x debian/rules
dh_clean
dh_clean: Compatibility levels before 9 are deprecated (level 7 in use)
cd . && python setup.py clean -a
running clean
'build/lib.linux-x86_64-2.7' does not exist -- can't clean it
'build/bdist.linux-x86_64' does not exist -- can't clean it
'build/scripts-2.7' does not exist -- can't clean it
rm -rf debian/python-module-stampdir
find "/home/stew/src/python-apptools_4.3" -name '*.py[co]' -delete
find "/home/stew/src/python-apptools_4.3" -name __pycache__ -type d -empty
-delete
find "/home/stew/src/python-apptools_4.3" -prune -name '*.egg-info' -exec
rm -rf '{}' ';'
 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building python-apptools using existing
./python-apptools_4.3.0.orig.tar.gz
dpkg-source: info: local changes detected, the modified files are:
 python-apptools_4.3/apptools/_version.py
dpkg-source: error: aborting due to unexpected upstream changes, see
/tmp/python-apptools_4.3.0-2.diff.lfR1uN
dpkg-source: info: you can integrate the local changes with dpkg-source
--commit
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui failed
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/python-modules-team/attachments/20190123/81fe75be/attachment-0001.html>