[Python-modules-team] Bug#936730: Bug#936730: impacket: Python2 removal in sid/bullseye

[Emmanuel Arias]

Hello! Raphael

I've write a comments on mentors. I don't know if you coulld see it

I made the changes of you review.

Cheers,
Arias Emmanuel
@eamanu
http://eamanu.com

El jue., 3 de oct. de 2019 a la(s) 19:40, Raphael Hertzog
(hertzog at debian.org) escribió:
>
> Hello,
>
> On Tue, 01 Oct 2019, Emmanuel Arias wrote:
> > I've just push to salsa and mentors
> > (https://mentors.debian.net/package/python-ldapdomaindump)
> > ldapdomaindump, maybe you can sponsor it :) thanks
>
> I can sponsor it but first I'd like you to make some changes:
>
> 1/ fix the Vcs-Git and Vcs-Browser URL to match the correct location
>    on salsa.debian.org
>
> 2/ point 1 prove that you based your work on the kali package so please
>    credit Kali in the changelog and keep the Kali copyright notice for the
>    debian/* files in debian/copyright.
>
> 3/ please reuse the same .orig.tar.gz (bit for bit!) for Debian as what we
>    used in Kali, otherwise Kali will not be able to import the Debian
>    package due to different conflicting files with the same name
>    (you have to redo "pristine-tar commit <tarball>" manually with
>    the correct file).
>
> $ wget http://http.kali.org/pool/main/p/python-ldapdomaindump/python-ldapdomaindump_0.9.1.orig.tar.gz
> $ sha1sum python-ldapdomaindump_0.9.1.orig.tar.gz
> 7df22d1fb6207e71c93abad6fa5e92179aa8b548  python-ldapdomaindump_0.9.1.orig.tar.gz
>
> Cheers,
> --
> Raphaël Hertzog ◈ Debian Developer
>
> Support Debian LTS: https://www.freexian.com/services/debian-lts.html
> Learn to master Debian: https://debian-handbook.info/get/