[Python-modules-team] Bug#936730: Bug#936730: impacket: Python2 removal in sid/bullseye

[Raphael Hertzog]

Hi,

On Fri, 27 Sep 2019, Emmanuel Arias wrote:
> I've just push to salsa the last changes.
> I will need sponsorship to upload it.

I took care of it. But I reverted the removal of python-impacket for
now, it still has reverse dependencies in Debian (and even more in Kali).

I had to cleanup a few things too, there was some upstream doc installed
in a wrong directory (/usr/share/doc/impacket). The changelog was
mishandled, the UNRELEASED entry for 0.9.19 should have been merged with
the 0.9.20.

And I had to rename debian/{install,links,examples} to debian/python3-impacket.*
but that's because I restored python-impacket. But in general, I find it
better to be explicit about the target package so I tend to avoid the
former names.

You had already pushed a tag, in general it's best when the uploader
pushes the tag so that if he has something to correct, he can do it.
Thus I dropped your tag and you will have to drop it on your side if you
want to get the correct one.

Cheers,

> El jue., 26 de sep. de 2019 a la(s) 17:02, Sophie Brun (
> sophie at offensive-security.com) escribió:
> 
> > Hi Emmanuel,
> >
> > ldapdomaindump is not in Debian but I packaged it for Kali last year.
> > The repo is here:
> > https://gitlab.com/kalilinux/packages/python-ldapdomaindump
> > I don't remember if the package is totally compliant with the Debian
> > policy but you can reuse it and improve it for Debian.
> >
> > For impacket: I build the package with the Kali package
> > python3-ldapdomaindump: no tests are really run.
> > I think we can just override dh_auto_test for the moment.
> >
> > I push few changes including a patch to avoid the installation of the
> > examples/*py as scripts in usr/bin/
> > There were not in usr/bin in python-impacket and I think it's better to
> > not have all these scripts in /usr/bin (but it's only my personal opinion).
> >
> > Cheers,
> >
> > Sophie
> >
> >
> > Le 26/09/2019 à 17:06, Emmanuel Arias a écrit :
> > > Hi Sophie, take care that I push some changes to salsa.
> > >
> > > the test are failing because |ldapdomaindump is not in debian (that is
> > correct?) I will package |ldapdomaindump.||
> > > ||
> > > ||
> > > ||So I think that the best solution is patch the tests to skipped it and
> > in  new version (when |ldapdomaindump) is in|||
> > > |||debian create a new version|||
> > > |||
> > > |||
> > > |||any suggestion?|||
> > > |||
> > > |||
> > > Cheers,
> > > Arias Emmanuel
> > > @eamanu
> > > http://eamanu.com
> > >
> > >
> > > El jue., 26 de sep. de 2019 a la(s) 11:03, Sophie Brun (
> > sophie at offensive-security.com <mailto:sophie at offensive-security.com>)
> > escribió:
> > >
> > >     Hello,
> > >
> > >     Le 26/09/2019 à 15:18, Emmanuel Arias a écrit :
> > >     > I will update the package.
> > >
> > >     I started to update the package (I need it for the reverse depends
> > in pkg-security team)
> > >
> > >     Can I push my changes on the git repo or maybe you prefer to update
> > everything yourself?
> > >
> > >     Cheers,
> > >     Sophie
> > >
> >

-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/