[Python-modules-team] Bug#952208: python-ftputil

[olivier sallou]

Le mer. 4 mars 2020 à 16:38, eamanu <eamanu at yaerobi.com> a écrit :

> Hi olivier,
>
> On 04/03/2020 12:13, olivier sallou wrote:
> > Hi,
> > I saw you started some work on python-ftputil to fix #952208.
> >
> > I just pushed to git repo a fix for that.
>
> I am a little confused, you just added description to the patch?
>

No, I added a patch "debian/patches/fix_tests_future.patch" as explained in
d/changelog


>
> Why do you  douplicate on d/changelog  the (Closes #bugnumber) sentence?
> [0]
>

was temporary, just referring what my patch impacts and will close this
issue.

The skip you made in your patch does not fix all issues, only workaround
them.


>
> >
> > Will you push new patch release soon? Or should I do?
>
> I'm DM and I will need sponsorhip.
>

I am DD, so I can upload it if you think it is "over" for you.


> >
> > I wonder however why you pushed a gbp.conf (not really expected usually)
> > setting branch as debian/master , which does not exists and default
> > being master.
>
> I push gbp.conf and set debian/master as default branch to be the
> repository according to the DPMT policy recommendation [1] and DEP-14 [2]
>

ooh ok, I see a "new" debian/master branch, which did not exists on my
local clone....
So I pushed to master branch instead of debian/master..... that's reason
why we do not "see" everything...

I have updated debian/master branch accordingly
I pushed my patch and disabled your patch to skip the tests from
d/patches/series
A gbp buildpackage works with all tests now.

Maybe master branch should be removed to avoid this kind of confusion


Olivier


> [0]
>
> https://salsa.debian.org/python-team/modules/python-ftputil/-/commit/a52fad2009b720882fed9bbed366b5e70e9154ae
> [1]
>
> https://salsa.debian.org/python-team/tools/python-modules/blob/master/policy.rst#branch-names
> [2] https://dep-team.pages.debian.net/deps/dep14/
>
> Cheers!
>
> --
> Emmanuel Arias
> @eamanu
> yaerobi.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/python-modules-team/attachments/20200304/9743de96/attachment-0001.html>