[Python-modules-team] Bug#953567: dh_sphinxdoc: incorrect 'does not load searchindex.js' with matplotlib/3.2.0?

[Sandro Tosi]

Package: sphinx-common
Version: 1.8.5-5
Severity: normal

Hello,
while preparing matplotlib/3.2.0 for unstable, dh_sphinxdoc fails with:

dh_sphinxdoc: error: debian/python-matplotlib-doc/usr/share/doc/python-matplotlib-doc/html/search.html does not load searchindex.js

with this mpl release, upstream switched to the "new" way to include
searchindex.js:

https://github.com/matplotlib/matplotlib/blob/v3.2.0/doc/_templates/search.html#L44

and indeed the resulting file has:

```
 tail -n7 debian/python-matplotlib-doc/usr/share/doc/python-matplotlib-doc/html/search.html
    </div>
</footer>
  <script type="text/javascript" src="searchindex.js" defer>
  </script>

  </body>
</html>
```

which should match the regex at:

https://salsa.debian.org/python-team/modules/sphinx/-/blob/debian/master/debian/dh-sphinxdoc/dh_sphinxdoc#L265

but it looks like it doesnt and still triggers

https://salsa.debian.org/python-team/modules/sphinx/-/blob/debian/master/debian/dh-sphinxdoc/dh_sphinxdoc#L284

Could this be a bug in dh_sphinxdoc? if so, could you please fix it?

Thanks,
Sandro

-- System Information:
Debian Release: 10.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages sphinx-common depends on:
ii  libjs-sphinxdoc  1.8.5-5

Versions of packages sphinx-common recommends:
ii  python-sphinx   1.8.5-5
ii  python3-sphinx  1.8.5-5

sphinx-common suggests no packages.

-- no debconf information