[Python-modules-team] Bug#815191: stdeb: Uses cmd line options removed in apt-file 3

[Andreas Henriksson]

Control: tags -1 + upstream confirmed

On Thu, Jun 23, 2016 at 05:35:04AM +0000, Niels Thykier wrote:
> On Fri, 19 Feb 2016 22:06:00 +0100 Niels Thykier <niels at thykier.net> wrote:
> > Source: stdeb
[...]
> > The stdeb file "stdeb/util.py" contains a function calling apt-file
> > twice.  First time with "--dummy --non-interactive" (and a second time
> > without).  The two options listed are not available in apt-file 3 and
> > the first call should probably be removed.
[...]
> I presume the particular path is not critical for stdeb's primary
> use-cases and have not bumped it to RC.
[...]

I'm looking at updating stdeb to 0.10 and can confirm that the
relevant code still seems to be in stdeb/util.py:

```
    if 1: 
        # do dry run on apt-file
        dry_run_args = args[:] + ['--dummy', '--non-interactive']
        cmd = subprocess.Popen(dry_run_args, stderr=subprocess.PIPE)
        returncode = cmd.wait()
        if returncode: 
            err_output = cmd.stderr.read()
            raise RuntimeError('Error running "apt-file search": ' +
                               err_output.strip())
```

It looks to me like if this code path is hit it will always error out.
I'm not sure how to trigger this code path though, and the commands
I've tested works fine....

Wanted to confirm the code is still around however. Tagging accordingly.
Someone should possibly bring this up with upstream if it hasn't already
been discussed.

Regards,
Andreas Henriksson