[Qa-jenkins-dev] Bug#863440: Please introduce "nice" variation in reproducible builds

Vagrant Cascadian vagrant at debian.org
Fri May 26 21:42:59 UTC 2017


On 2017-05-26, Chris Lamb wrote:
> Please introduce a "nice" variation in reproducible builds (from IRC):
>
>      vagrantc was just thinking that the nice level should be higher
>      for the first build, under the same  premise that we allow the
>      2nd build more hours to complete and then i realized that was
>      also a potential build variation :)
>
>      […]
>
>      the second build should have a lower nice than the first so as
>      to get prioritized better

Thanks for the *quick* response in git, holger! :)

I would recommend having the first build be a higher nice level than the
second build:

diff --git a/bin/reproducible_build.sh b/bin/reproducible_build.sh
index 9018ceb6..8b40acd4 100755
--- a/bin/reproducible_build.sh
+++ b/bin/reproducible_build.sh
@@ -633,7 +633,7 @@ EOF
 		echo "BUILDDIR=/build" >> "$TMPCFG"
 	fi
 	# remember to change the sudoers setting if you change the following command
-	( sudo timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice \
+	( sudo timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice -n 12\
 	  /usr/sbin/pbuilder --build \
 		--configfile $TMPCFG \
 		--debbuildopts "-b --buildinfo-id=${ARCH}" \
@@ -701,7 +701,7 @@ EOF
 	# remember to change the sudoers setting if you change the following command
 	# (the 2nd build gets a longer timeout trying to make sure the first build
 	# aint wasted when then 2nd happens on a highly loaded node)
-	sudo timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice -n 12 \
+	sudo timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice \
 		/usr/bin/unshare --uts -- \
 		/usr/sbin/pbuilder --build \
 			--configfile $TMPCFG \
diff --git a/bin/reproducible_common.sh b/bin/reproducible_common.sh
index 9c93d3cf..3b585db7 100755
--- a/bin/reproducible_common.sh
+++ b/bin/reproducible_common.sh
@@ -404,7 +404,7 @@ write_variation_table() {
 		write_page "<tr><td>env BUILDUSERNAME</td><td>BUILDUSERNAME=\"pbuilder1\"</td><td>BUILDUSERNAME=\"pbuilder2\"</td></tr>"
 		write_page "<tr><td>env USER</td><td>USER=\"pbuilder1\"</td><td>USER=\"pbuilder2\"</td></tr>"
 		write_page "<tr><td>env HOME</td><td>HOME=\"/nonexistent/first-build\"</td><td>HOME=\"/nonexistent/second-build\"</td></tr>"
-		write_page "<tr><td>niceness</td><td>10</td><td>12</td></tr>"
+		write_page "<tr><td>niceness</td><td>12</td><td>10</td></tr>"
 		write_page "<tr><td>uid</td><td>uid=1111</td><td>uid=2222</td></tr>"
 		write_page "<tr><td>gid</td><td>gid=1111</td><td>gid=2222</td></tr>"
 		write_page "<tr><td>/bin/sh</td><td>/bin/dash</td><td>/bin/bash</td></tr>"


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/qa-jenkins-dev/attachments/20170526/83e4a63b/attachment.sig>


More information about the Qa-jenkins-dev mailing list