Bug#1147469: reproducible-builds: must not set 'nocheck' on only one build

[Thorsten Glaser]

Package: jenkins.debian.org
Severity: important
X-Debbugs-Cc: tg at mirbsd.de

I’ve recently found out that reproducible-builds nowadays fails
packages which produce different output when 'nocheck' is set vs.
unset.

This is wrong.

If (if!) a 'nocheck' build *profile* is supported by the package,
then, if that build *profile* is set, the binary packages may not
differ.

But the 'nocheck' build option *is* allowed to have binary
differences, and this is something important for various corner
cases.

So, please add it to DEB_BUILD_OPTIONS on either no or all builds,
and investigate into setting the 'nocheck' build *profile* on only
one build *iff* the package supports it. I’m not exactly sure how
to actually test for that, but if it only gets added to the variable
DEB_BUILD_PROFILES but not DEB_BUILD_OPTIONS, then it can just be
ignored by packages not supporting the 'nocheck' *profile*.