[Qa-jenkins-scm] [jenkins.debian.net] 01/02: reproducible: explain and remove FIXME

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch master
in repository jenkins.debian.net.

commit bf60651182fa1484f3bc3aae9e575de3da4805c0
Author: Holger Levsen <holger at layer-acht.org>
Date:   Thu May 14 14:53:01 2015 +0200

    reproducible: explain and remove FIXME
---
 bin/reproducible_html_graphs.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/bin/reproducible_html_graphs.sh b/bin/reproducible_html_graphs.sh
index 94da97f..bcc4eff 100755
--- a/bin/reproducible_html_graphs.sh
+++ b/bin/reproducible_html_graphs.sh
@@ -180,6 +180,9 @@ gather_meta_stats() {
 		META_LIST=$(cat $PKGSET_PATH)
 		if [ ! -z "$META_LIST" ] ; then
 			META_WHERE=""
+			# gather data about all packages we know about
+			# as a result, unknown packages in the package set
+			# are silently ignored
 			for PKG in $META_LIST ; do
 				if [ -z "$META_WHERE" ] ; then
 					META_WHERE="s.name in ('$PKG'"
@@ -455,7 +458,7 @@ create_pkg_sets_pages() {
 		create_pkg_sets_navigation
 		write_page "<hr />"
 		META_RESULT=true
-		gather_meta_stats $i	# FIXME: this ignores unknown packages...
+		gather_meta_stats $i
 		if $META_RESULT ; then
 			MAINLABEL[6]="Reproducibility status for packages in $SUITE from '${META_PKGSET[$i]}'"
 			YLABEL[6]="Amount (${META_PKGSET[$i]} packages)"

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/qa/jenkins.debian.net.git