[Qa-jenkins-scm] [jenkins.debian.net] 01/01: reproducible: don't save the reschedule reason in the DB

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch master
in repository jenkins.debian.net.

commit 5b71180cb97a9a79b40b3fd025dfe17a48712848
Author: Mattia Rizzolo <mattia at debian.org>
Date:   Mon Dec 14 18:34:01 2015 +0000

    reproducible: don't save the reschedule reason in the DB
    
    That was actually a bad idea, given that we don't check on input execute the
    with the given string right away.
    
    Also, we're not really interested in this, so once convenient we can also remove
    the column from the DB.
---
 TODO                                 | 1 +
 bin/reproducible_remote_scheduler.py | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/TODO b/TODO
index 883933c..3e225c0 100644
--- a/TODO
+++ b/TODO
@@ -136,6 +136,7 @@ This is about Debian, below are more todo entries for other projects…
 * on SIGTERM, also ssh to remote host and cleanup there! (via ssh &)
 
 * higher prio:
+** remove the rescheduling reason from the DB, that's really not needed
 ** scheduler should automatically schedule 404 packages
 ** explain status in plain english on each coreboot/openwrt/netbsd/freebsd page, also on the Debian dashboard plus add an "executive summary about reproducible builds in the free software world"
 *** get the content for "<h2>status of $1</h2>" from notes.git/friends.yaml or such
diff --git a/bin/reproducible_remote_scheduler.py b/bin/reproducible_remote_scheduler.py
index 331f7b3..4afe29d 100755
--- a/bin/reproducible_remote_scheduler.py
+++ b/bin/reproducible_remote_scheduler.py
@@ -233,7 +233,6 @@ if amount + len(ids) > 200 and not local:
 to_schedule = []
 save_schedule = []
 artifacts_value = 1 if artifacts else 0
-reason = reason if reason else None
 if notify_on_start:
     do_notify = 2
 elif notify or artifacts:
@@ -242,7 +241,7 @@ else:
     do_notify = 0
 for id in ids:
     to_schedule.append((id, date, artifacts_value, str(do_notify), requester,
-                        reason))
+                        None))
     save_schedule.append((id, requester, epoch))
 log.debug('Packages about to be scheduled: ' + str(to_schedule))
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/qa/jenkins.debian.net.git