[Qa-jenkins-scm] [jenkins.debian.net] 01/01: reproducible debian: maintenance: do not dump database ACL in the backups

Holger Levsen holger at layer-acht.org
Fri Jun 16 09:15:31 UTC 2017


This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch master
in repository jenkins.debian.net.

commit ef7fe352e2bb940ac2495e1f303d5ca7c8385b38
Author: Mattia Rizzolo <mattia at debian.org>
Date:   Thu Jun 15 20:54:06 2017 +0200

    reproducible debian: maintenance: do not dump database ACL in the backups
    
    1) they are totally useless and actually problematic for people using
    this dumps in dev envs (as restore fails due to lack of 'jenkins' user,
    or lack of superuser powers to commit those changes)
    2) we don't have any real ACL, jenkins can do pretty much anything in
    the db, so the information is actually just noise
    
    Signed-off-by: Mattia Rizzolo <mattia at debian.org>
    Signed-off-by: Holger Levsen <holger at layer-acht.org>
---
 bin/reproducible_maintenance.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/reproducible_maintenance.sh b/bin/reproducible_maintenance.sh
index be830f2..66cee4a 100755
--- a/bin/reproducible_maintenance.sh
+++ b/bin/reproducible_maintenance.sh
@@ -40,7 +40,7 @@ if [ "$HOSTNAME" = "$MAINNODE" ] ; then
 	if [ ! -f $BACKUPFILE.xz ] ; then
 		# make the backup
 		DATE=$(date '+%Y-%m-%d')
-		pg_dump -O --column-inserts $PGDATABASE > "$BACKUPFILE"
+		pg_dump -x -O --column-inserts $PGDATABASE > "$BACKUPFILE"
 		xz "$BACKUPFILE"
 
 		# make the backup public

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/qa/jenkins.debian.net.git



More information about the Qa-jenkins-scm mailing list