[Qa-jenkins-scm] [Git][qa/jenkins.debian.net][master] 2 commits: reproducible: html_breakages: remove pbuilder_dep_fail(), we had the depwait state for a long time

[Mattia Rizzolo]

Mattia Rizzolo pushed to branch master at Debian QA / jenkins.debian.net


Commits:
3030488f by Mattia Rizzolo at 2018-06-20T14:18:44+02:00
reproducible: html_breakages: remove pbuilder_dep_fail(), we had the depwait state for a long time

Signed-off-by: Mattia Rizzolo <mattia at debian.org>

- - - - -
953c5276 by Mattia Rizzolo at 2018-06-20T14:19:15+02:00
reproducible: html_breakages: check for dbdtxt and deal with the new timeout status

Signed-off-by: Mattia Rizzolo <mattia at debian.org>

- - - - -


1 changed file:

- bin/reproducible_html_breakages.py


Changes:

=====================================
bin/reproducible_html_breakages.py
=====================================
--- a/bin/reproducible_html_breakages.py
+++ b/bin/reproducible_html_breakages.py
@@ -11,7 +11,6 @@
 # Build a page full of CI issues to investigate
 
 import os
-import re
 import csv
 import time
 import os.path
@@ -67,6 +66,7 @@ def count_pkgs(pkgs_to_count=[]):
              counted_pkgs.append(pkg)
     return len(counted_pkgs)
 
+
 def not_unrep_with_dbd_file():
     log.info('running not_unrep_with_dbd_file check...')
     bad_pkgs = []
@@ -79,10 +79,16 @@ def not_unrep_with_dbd_file():
         eversion = strip_epoch(version)
         dbd = DBD_PATH + '/' + suite + '/' + arch + '/' + pkg + '_' + \
             eversion + '.diffoscope.html'
+        dbdtxt = '{}/{}/{}/{}_{}.diffoscope.txt.gz'.format(
+            DBDTXT_PATH, suite, arch, pkg, eversion)
         if os.access(dbd, os.R_OK):
             bad_pkgs.append((pkg, version, suite, arch))
             log.warning(dbd + ' exists but ' + suite + '/' + arch + '/' + pkg + ' (' + version + ')'
                         ' is not FTBR.')
+        if os.access(dbdtxt, os.R_OK):
+            bad_pkgs.append((pkg, version, suite, arch))
+            log.warning(dbdtxt + ' exists but ' + suite + '/' + arch + '/' + pkg + ' (' + version + ')'
+                        ' is not FTBR.')
     return bad_pkgs
 
 
@@ -110,7 +116,7 @@ def lack_buildinfo():
     query = '''SELECT s.name, r.version, s.suite, s.architecture
                FROM sources AS s JOIN results AS r ON r.package_id=s.id
                WHERE r.status NOT IN
-                ('blacklisted', 'NFU', 'FTBFS', 'depwait', 'E404', '')
+                ('blacklisted', 'NFU', 'FTBFS', 'timeout', 'depwait', 'E404')
                ORDER BY s.name ASC, s.suite DESC, s.architecture ASC'''
     results = query_db(query)
     for pkg, version, suite, arch in results:
@@ -124,33 +130,6 @@ def lack_buildinfo():
     return bad_pkgs
 
 
-def pbuilder_dep_fail():
-    log.info('running pbuilder_dep_fail check...')
-    bad_pkgs = []
-    # we only care about these failures in the !unstable !experimental suites
-    # as they happen all the time in there, as packages are buggy
-    # and specific versions also come and go
-    query = '''SELECT s.name, r.version, s.suite, s.architecture
-               FROM sources AS s JOIN results AS r ON r.package_id=s.id
-               WHERE r.status = 'FTBFS'
-               AND s.suite NOT IN ('unstable', 'experimental')
-               ORDER BY s.name ASC, s.suite DESC, s.architecture ASC'''
-    results = query_db(query)
-    for pkg, version, suite, arch in results:
-        eversion = strip_epoch(version)
-        rbuild = RBUILD_PATH + '/' + suite + '/' + arch + '/' + pkg + '_' + \
-            eversion + '.rbuild.log'
-        if os.access(rbuild, os.R_OK):
-            log.debug('\tlooking at ' + rbuild)
-            with open(rbuild, "br") as fd:
-                for line in fd:
-                    if re.search(b'E: pbuilder-satisfydepends failed.', line):
-                        bad_pkgs.append((pkg, version, suite, arch))
-                        log.warning(suite + '/' + arch + '/' + pkg + ' (' + version +
-                                    ') failed to satisfy its dependencies.')
-    return bad_pkgs
-
-
 def alien_log(directory=None):
     if directory is None:
         bad_files = []
@@ -359,12 +338,6 @@ def update_stats_breakages(diffoscope_timeouts, diffoscope_crashes):
 
 def gen_html():
     html = ''
-    # pbuilder-satisfydepends failed
-    broken_pkgs = pbuilder_dep_fail()
-    if broken_pkgs != []:
-        html += '<h3>Breakage caused by broken packages</h3>'
-        html += _gen_packages_html('failed to satisfy their build-dependencies:',
-                         broken_pkgs)
     # diffoscope troubles
     html += '<h2>Breakage involving diffoscope</h2>'
     without_dbd, bad_dbd, sources_without_dbd = unrep_with_dbd_issues()



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/compare/a903dd7b539cdf37e8ec11723252d2256d784b5f...953c5276897ac00400ca223d60084fb5ade02e7f

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/compare/a903dd7b539cdf37e8ec11723252d2256d784b5f...953c5276897ac00400ca223d60084fb5ade02e7f
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20180620/c3c50d43/attachment-0001.html>