[Qa-jenkins-scm] [Git][qa/jenkins.debian.net][master] 3 commits: reproducible Debian: cleanup, drop a pointless "FIXME"

[Holger Levsen]

Holger Levsen pushed to branch master at Debian QA / jenkins.debian.net


Commits:
3975ac64 by Holger Levsen at 2019-02-08T17:10:09Z
reproducible Debian: cleanup, drop a pointless "FIXME"

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -
9c099966 by Holger Levsen at 2019-02-08T17:11:06Z
reproducible Debian: cleanup, drop another FIXME

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -
a0c990a2 by Holger Levsen at 2019-02-08T17:13:04Z
d-i: drop FIXME from deprecated code path

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -


3 changed files:

- bin/cgi-bin/nph-logwatch
- bin/d-i_build.sh
- bin/reproducible_html_packages.py


Changes:

=====================================
bin/cgi-bin/nph-logwatch
=====================================
@@ -1,6 +1,6 @@
 #!/bin/bash
 
-# Copyright © 2017-2018 Holger Levsen (holger at layer-acht.org)
+# Copyright © 2017-2019 Holger Levsen (holger at layer-acht.org)
 # released under the GPLv=2
 
 set -e
@@ -55,7 +55,7 @@ elif [ ! -z "$(ps fax|grep -v grep|grep 'reproducible_worker $WORKER.sh ')" ] ;
 		zcat $FILE.gz
 	fi
 #
-# FIXME: we should really just convert 'latest' into a number here and use the tail below… 
+# maybe we should just convert 'latest' into a number here and use the tail below…
 #
 elif [ "$BUILD" = "latest" ] ; then
 	if [ -f $FILE.gz ] ; then


=====================================
bin/d-i_build.sh
=====================================
@@ -1,6 +1,6 @@
 #!/bin/bash
 
-# Copyright 2012-2018 Holger Levsen <holger at layer-acht.org>
+# Copyright 2012-2019 Holger Levsen <holger at layer-acht.org>
 # 		 2016 Phil Hands <phil at hands.com>
 # released under the GPLv=2
 
@@ -85,7 +85,7 @@ preserve_artifacts() {
 		ls -ltrc $ISO_DIR
 
 		if [ "$HOSTNAME" = "jenkins" ] ; then
-			# FIXME this rsync should probably be in a separate job that the one on pb10 could then depend on -- otherwise race conditions seem to lurk
+			# this rsync should probably be in a separate job that the one on pb10 could then depend on -- otherwise race conditions seem to lurk
 			echo "and rsync them to the target node ($ISO_TEST_HOST):"
 			ssh -o 'Batchmode = yes' $ISO_TEST_HOST mkdir -p $ISO_DIR
 			rsync -v -e "ssh -o 'Batchmode = yes'" -r $ISO_DIR/ $ISO_TEST_HOST:$ISO_DIR/


=====================================
bin/reproducible_html_packages.py
=====================================
@@ -315,7 +315,6 @@ def gen_history_page(package, arch=None):
         for r in package.history:
             # make a copy, since we modify in place
             record = dict(r)
-            # FIXME - hacky, should be rethought one day
             # skip records for suites that are unknown to us (i.e. other distro)
             if record['suite'] not in SUITES:
                 continue



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/compare/cd3a475df36e47ed567c9baf5989e30494e6f026...a0c990a22bee1bbd17164558ce4007e8b3491952

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/compare/cd3a475df36e47ed567c9baf5989e30494e6f026...a0c990a22bee1bbd17164558ce4007e8b3491952
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20190208/dd29bab3/attachment-0001.html>