[Qa-jenkins-scm] [Git][qa/jenkins.debian.net][master] 4 commits: reproducible Arch Linux: drop FIXME as we need a bigger rewrite anyway

[Holger Levsen]

Holger Levsen pushed to branch master at Debian QA / jenkins.debian.net


Commits:
707c70eb by Holger Levsen at 2019-02-08T17:17:39Z
reproducible Arch Linux: drop FIXME as we need a bigger rewrite anyway

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -
052e30fe by Holger Levsen at 2019-02-08T17:19:14Z
reproducible Arch Linux: drop unclear FIXME

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -
7d07fa0d by Holger Levsen at 2019-02-08T17:20:22Z
d-i: turn nagging FIXME into non-nagging TODO

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -
1193a073 by Holger Levsen at 2019-02-08T17:25:45Z
reproducible Arch Linux: drop one FIXME which is spelled out in the TODO file already

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -


3 changed files:

- bin/d-i_build.sh
- bin/reproducible_common.sh
- bin/reproducible_html_archlinux.sh


Changes:

=====================================
bin/d-i_build.sh
=====================================
@@ -150,7 +150,7 @@ EOF
 	NUM_CPU=$(nproc)
 	#
 	# if we got a valid TRIGGERING_BRANCH passed in as a parameter from the triggering job
-	# then grab the generated udebs.  FIXME -- we need to work out a way of cleaning up old branches
+	# then grab the generated udebs.  TODO -- we need to work out a way of cleaning up old branches
 	#
 	if udeb_dir=$(replace_origin_pu "/srv/udebs/" $TRIGGERING_BRANCH) ; then
 		cp $udeb_dir/*.udeb build/localudebs


=====================================
bin/reproducible_common.sh
=====================================
@@ -1007,10 +1007,8 @@ create_pkg_html() {
 	#
 	#
 	if [ -z "$(cd $ARCHLINUX_PKG_PATH/ ; ls *.pkg.tar.xz.html 2>/dev/null)" ] ; then
-		# this horrible if elif elif elif elif...  monster is needed because
-		# https://lists.archlinux.org/pipermail/pacman-dev/2017-September/022156.html
-	        # has not yet been merged yet...
-		# FIXME: this has been merged, see http://jlk.fjfi.cvut.cz/arch/manpages/man/makepkg
+		# this horrible if elif elif elif elif...  monster should be replaced
+		# by using pacman's exit code which is possible since sometime in 2018
 
 		# check different states and figure out what the page should look like
 		if find_in_buildlogs '^error: failed to prepare transaction \(conflicting dependencies\)'; then


=====================================
bin/reproducible_html_archlinux.sh
=====================================
@@ -455,7 +455,7 @@ if [ -z "$1" ] ; then
 	WIDTH=1920
 	HEIGHT=960
 	# variables related to the stats we update
-	# FIELDS[0]="datum, reproducible, FTBR, FTBFS, other, untested" # FIXME: for this Arch Linux still uses a .csv file...
+	# FIELDS[0]="datum, reproducible, FTBR, FTBFS, other, untested" # for this Arch Linux still uses a .csv file...
 	FIELDS[1]="datum"
 	for i in reproducible FTBR FTBFS other ; do
 	        for j in $SUITES ; do
@@ -475,7 +475,7 @@ if [ -z "$1" ] ; then
 	rm $HTML_REPOSTATS > /dev/null
 elif [ -z "$2" ] ; then
 	echo "$(date -u) - $0 needs two params or none, exiting."
-	#FIXME: in future also except all core extra multilib community
+	# add code here to also except core, extra, multilib or community...
 	exit 1
 else
 	REPOSITORY=$1



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/compare/a0c990a22bee1bbd17164558ce4007e8b3491952...1193a07318044f98139c3b29d49bfe12ecc4fcb6

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/compare/a0c990a22bee1bbd17164558ce4007e8b3491952...1193a07318044f98139c3b29d49bfe12ecc4fcb6
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20190208/a8f8f49d/attachment-0001.html>