[Qa-jenkins-scm] [Git][qa/jenkins.debian.net][master] openwrt: fixup readlines/splitlines in rebuild

[Holger Levsen]

Holger Levsen pushed to branch master at Debian QA / jenkins.debian.net


Commits:
dcbacce5 by Paul Spooren at 2019-10-08T09:51:24Z
openwrt: fixup readlines/splitlines in rebuild

using readlines() causes the array to contain extra newlines, breaking
the email.parser. This approach solves the issue.

Signed-off-by: Paul Spooren <mail at aparcar.org>
Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -


1 changed file:

- bin/reproducible_openwrt_rebuild.py


Changes:

=====================================
bin/reproducible_openwrt_rebuild.py
=====================================
@@ -452,7 +452,9 @@ def diffoscope_multithread():
 def store_results():
     with open(target_dir + "/packages/Packages.manifest") as rebuild_manifest:
         origin_manifest = get_file(download_url + "/packages/Packages.manifest")
-        result = show_list_difference(origin_manifest, rebuild_manifest.readlines())
+        result = show_list_difference(
+            origin_manifest, rebuild_manifest.read().splitlines()
+        )
         insert_into_db(result, "{}-rebuild".format(version))
 
 



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/commit/dcbacce5c54a16a13623d8d0c31e643b250690e6

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/commit/dcbacce5c54a16a13623d8d0c31e643b250690e6
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20191008/797113af/attachment-0001.html>