[Qa-jenkins-scm] [Git][qa/jenkins.debian.net][master] djm: show FIXMEs with --verbose

[Holger Levsen (@holger)]

Holger Levsen pushed to branch master at Debian QA / jenkins.debian.net


Commits:
9d77ec77 by Holger Levsen at 2023-05-17T01:08:30+02:00
djm: show FIXMEs with --verbose

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -


2 changed files:

- TODO
- bin/djm


Changes:

=====================================
TODO
=====================================
@@ -36,21 +36,6 @@ See link:https://jenkins.debian.net/userContent/about.html["about jenkins.debian
 ** options: --press-enter --dont-wait-for-enter, default being wait for enter.
 ** update documentation refering to deploy_jdn to djm
 *** ups, there's no doc on deploy_jdn anyway
-** show FIXMEs?
-show_fixmes() {
-	local BASEDIR="$(dirname "$(readlink -e $0)")"
-	# FIXME: if ! [ -f bin/djm...
-	local TMPFILE=$(mktemp)
-	rgrep FI[X]ME $BASEDIR/* | grep -v $BASEDIR/TODO | grep -v echo > $TMPFILE || true
-	if [ -s $TMPFILE ] ; then
-		echo
-		echo Existing FIXME statements:
-		echo
-		cat $TMPFILE | sed "s#$PWD#...#g"
-		echo
-	fi
-	rm -f $TMPFILE
-}
 ** also log an id, so that one command effecting several hosts is counted as on action
 *** make actions triggering 'all' be only one entry in the djm logfile -> more sensible stats
 ** automatically backup+cleanup logs on the first of the month


=====================================
bin/djm
=====================================
@@ -608,11 +608,39 @@ djm_init() {
 	rm $DUMMY
 }
 
+show_fixmes() {
+	local BASEDIR="$(dirname "$(readlink -e $0)")"
+	local TMPFILE=$(mktemp)
+	rgrep FI[X]ME $BASEDIR/* | grep -v $BASEDIR/TODO | grep -v echo > $TMPFILE || true
+	if [ -s $TMPFILE ] ; then
+		echo
+		echo Existing FIXME statements:
+		echo
+		cat $TMPFILE | sed "s#$PWD#...#g"
+		echo
+	fi
+	rm -f $TMPFILE
+	seperator
+}
+
+djm_end() {
+	if $VERBOSE ; then
+		show_fixmes
+	fi
+}
+
 #
 # main
 #
 case $MODE in
-	report)		djm_init ; djm_report			;;
-	djm)		djm_init ; djm_do "$1" "$2" "$3" "$4"	;;
-	help)		show_help				;;
+	report)		djm_init
+			djm_report
+			djm_end
+			;;
+	djm)		djm_init
+			djm_do "$1" "$2" "$3" "$4"
+			djm_end
+			;;
+	help)		show_help
+			;;
 esac



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/9d77ec77a759d74d835311587b057d80e16a5727

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/9d77ec77a759d74d835311587b057d80e16a5727
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20230516/e686f22a/attachment-0001.htm>