[Git][qa/jenkins.debian.net][master] reproducible node health: cleanup failed rb-diffoscope*.services but still warn

[Holger Levsen (@holger)]

Holger Levsen pushed to branch master at Debian QA / jenkins.debian.net


Commits:
093e0f28 by Holger Levsen at 2024-04-13T23:49:42+02:00
reproducible node health: cleanup failed rb-diffoscope*.services but still warn

Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -


1 changed file:

- bin/reproducible_node_health_check.sh


Changes:

=====================================
bin/reproducible_node_health_check.sh
=====================================
@@ -206,19 +206,20 @@ if ! systemctl --user is-system-running > /dev/null; then
 	systemctl --user list-units --state=error,failed | grep " failed " > $SERVICES || true
 	echo "$(date -u) - problematic services found:"
 	cat $SERVICES
-	# if there are more than 10 failed user services...
-	if [ $(cat $SERVICES|wc -l) -gt 10 ] ; then
-		 # only resetting failed rb-diffoscope*.services
-		 for SCOPE in $(grep rb-diffoscope $SERVICES| awk '{ print $2} ') ; do
-			echo "$(date -u) - resetting failed $SCOPE..."
-		        systemctl --user reset-failed $SCOPE
-		 done
-	else
-		echo "Manual cleanup needed."
+	# we only reset failed rb-diffoscope*.services, as we know they are from
+	# diffoscope crashes and are shown on https://tests.reproducible-builds.org/debian/index_breakages.html
+	# so bugs against diffoscope can be filed
+	if $(grep -q rb-diffoscope $SERVICES) ; then
 		echo "You might want to check these builds:"
 		# present nice clickable URLs in jenkins job log
 		grep "● rb-diffoscope" $SERVICES |awk ' { print "https://tests.reproducible-builds.org/debian/rb-pkg/"$10 "/" $8  }' | cut -d '/' -f1-8 | sed 's#$#.html#'
-
+		# now resetting those user services
+		for SCOPE in $(grep rb-diffoscope $SERVICES| awk '{ print $2} ') ; do
+			echo "$(date -u) - resetting failed $SCOPE..."
+			systemctl --user reset-failed $SCOPE
+		done
+	else
+		echo "Manual cleanup needed."
 	fi
 	DIRTY=true
 	rm -f $SERVICES



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/093e0f28b242393a27a145a24038c04b90058b5a

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/093e0f28b242393a27a145a24038c04b90058b5a
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20240413/2849b6c7/attachment-0001.htm>