[R-pkg-team] Comments regarding r-cran-maxstat_0.7-25-1_amd64.changes

Scott Kitterman ftpmaster at ftp-master.debian.org
Tue Apr 7 00:50:22 BST 2020


This is a Format 3.0 (Quilt) package, but it has a .pc directory in it. Please
don't include the .pc directory.  It will lead to nothing but trouble.

Debian/copyright is incomplete.  src/maxstatpermdist.c:

  maxstatpermdist : Simulate Distribution of Maximally Selected Rank Statistics
  Copyright (C) 2003  Torsten Hothorn 
                      <Torsten.Hothorn at rzmail.uni-erlangen.de>
    
  This program is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation; either version 2 of the License, or (at
  your option) any later version.
            
  This program is distributed in the hope that it will be useful, but
  WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  General Public License for more details.
                   
  You should have received a copy of the GNU General Public License
  along with this program; if not, write to the Free Software
  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA.

Since the license is the same as is documented in debian/copyright I am going
to go ahead and accept the package, but it is RC buggy as is because the GPL
requires copyright statements be preserved in the binaries.  Fix on your next
upload.

Scott K





More information about the R-pkg-team mailing list