[R-pkg-team] Comments regarding r-bioc-tcgabiolinks_2.14.1+dfsg-1_amd64.changes

[Scott Kitterman]

I am going to accept this package, but it is missing a copyright attribution.
This needs to be fixed in your next upload.  From R/internal.R

#
#  ggbiplot.r
#
#  Copyright 2011 Vincent Q. Vu.
#
#  This program is free software; you can redistribute it and/or
#  modify it under the terms of the GNU General Public License
#  as published by the Free Software Foundation; either version 2
#  of the License, or (at your option) any later version.
#
#  This program is distributed in the hope that it will be useful,
#  but WITHOUT ANY WARRANTY; without even the implied warranty of
#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#  GNU General Public License for more details.
#
#  You should have received a copy of the GNU General Public License
#  along with this program; if not, write to the Free Software
#  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

Two things, one mandatory, one optional:

The license requires preservation of the copyright statement, so Vicent Q. Wu
has to be added to debian/copyright.

The balance of this package is GPL-3+.  This this is GPL-2+, the current
debian/copyright infers that Debian will be distributing this only under the
terms of GPL-3+.  I might be better to add explicit mention of part of this
file being GPL-2+, but it is not strictly required.

Scott K