[R-pkg-team] Bug#961498: AW: Description file of r-cran-sjlabelled seems to specify wrong depencency from haven (Was: Bug#961498: r-cran-sjplot: missing test dependency on r-cran-haven)

[Daniel Lüdecke]

Suggesting the package 'haven' is correct, because it's only used conditionally now. That change was intentional, to reduce package dependencies. See also current sjlablled on CRAN (https://cran.r-project.org/web/packages/sjlabelled/index.html).

Best
Daniel

-----Ursprüngliche Nachricht-----
Von: Andreas Tille [mailto:andreas at an3as.eu] 
Gesendet: Montag, 25. Mai 2020 13:10
An: Adrian Bunk <bunk at debian.org>; 961498 at bugs.debian.org; 961419 at bugs.debian.org; debian-r at lists.debian.org; Daniel Lüdecke <d.luedecke at uke.de>
Betreff: Description file of r-cran-sjlabelled seems to specify wrong depencency from haven (Was: Bug#961498: r-cran-sjplot: missing test dependency on r-cran-haven)

Hi,

there is a series of build failures connected to missing r-cran-haven.
Formerly r-cran-sjlabelled dependend from r-cran-haven - and IMHO that should remain that way:

r-cran-sjlabelled(master) $ grep haven R/* | grep -i required
R/as_label.R:        stop("Package 'haven' required for this function. Please install it.")
R/get_na.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/remove_labels.R:      stop("Package 'haven' required for this function. Please install it.")
R/remove_labels.R:    stop("Package 'haven' required for this function. Please install it.")
R/set_labels.R:          stop("Package 'haven' required for this function. Please install it.")
R/set_na.R:    stop("Package 'haven' required for this function. Please install it.")
R/write.R:    stop("Package 'haven' required for this function. Please install it.")
R/zap_labels.R:    stop("Package 'haven' required for this function. Please install it.")


I think it is just wrong that DESCRIPTION of sjlabelled just

   Suggests: haven (>= 1.1.2)

I don't understand the difference between Depends and Imports in R DESCRIPTION files but both are translated to Debian Depends - and this should be used here.

Kind regards

     Andreas.

On Mon, May 25, 2020 at 01:10:10PM +0300, Adrian Bunk wrote:
> Source: r-cran-sjplot
> Version: 2.8.3-2
> Severity: serious
> 
> https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-sjplot/5
> 625656/log.gz
> 
> ...
> > library(testthat)
> > library(sjPlot)
> > 
> > if (length(strsplit(packageDescription("sjPlot")$Version, 
> > "\\.")[[1]]) > 3) {
> +   Sys.setenv("RunAllsjPlotTests" = "yes") }
> > 
> > test_check("sjPlot")
> ── 1. Error: (unknown) (@test-plot_model_std.R#15)  
> ──────────────────────────── Package 'haven' required for this function. Please install it.
> Backtrace:
>  1. sjmisc::to_factor(efc, e42dep, c172code, c161sex)  2. 
> sjmisc:::to_fac_helper(.dat[[i]], add.non.labelled, ref.lvl)  5. 
> sjlabelled::set_labels(...)  6. sjlabelled:::set_labels_helper(...)
> 
> ══ testthat results  
> ═══════════════════════════════════════════════════════════
> [ OK: 2 | SKIPPED: 0 | WARNINGS: 12 | FAILED: 1 ] ...
> 
> 
> r-cran-sjlabelled no longer depends on r-cran-haven.
> _______________________________________________
> R-pkg-team mailing list
> R-pkg-team at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/r-pkg-team

--
http://fam-tille.de

--

_____________________________________________________________________

Universitätsklinikum Hamburg-Eppendorf; Körperschaft des öffentlichen Rechts; Gerichtsstand: Hamburg | www.uke.de
Vorstandsmitglieder: Prof. Dr. Burkhard Göke (Vorsitzender), Joachim Prölß, Prof. Dr. Blanche Schwappach-Pignataro, Marya Verdel
_____________________________________________________________________

SAVE PAPER - THINK BEFORE PRINTING