[R-pkg-team] Bug#970001: r-cran-tibble: autopkgtest failure

[Lucas Kanashiro]

Source: r-cran-tibble
Version: 3.0.3-1
Severity: normal
Tag: patch

Dear Maintainer,

r-cran-tibble has not migrated to testing because of a regression detected by autopkgtest:

https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-tibble/6964425/log.gz

This is the important part:

> library("testthat")
> 
> test_check("tibble")
Loading required package: tibble
── 1. Error: lubridate::Period (#784) (@test-tribble.R#173)  ───────────────────
there is no package called ‘lubridate’
Backtrace:
  1. testthat::expect_equal(...)
  7. lubridate::days
  8. base::getExportedValue(pkg, name)
  9. base::asNamespace(ns)
 10. base::getNamespace(ns)
 11. base::loadNamespace(name)
 12. base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 13. base:::withOneRestart(expr, restarts[[1L]])
 14. base:::doWithOneRestart(return(expr), restart)

── 2. Error: formattable (#785) (@test-tribble.R#180)  ─────────────────────────
there is no package called ‘formattable’
Backtrace:
  1. testthat::expect_equal(...)
  7. formattable::formattable
  8. base::getExportedValue(pkg, name)
  9. base::asNamespace(ns)
 10. base::getNamespace(ns)
 11. base::loadNamespace(name)
 12. base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 13. base:::withOneRestart(expr, restarts[[1L]])
 14. base:::doWithOneRestart(return(expr), restart)

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 1413 | SKIPPED: 108 | WARNINGS: 0 | FAILED: 2 ]
1. Error: lubridate::Period (#784) (@test-tribble.R#173) 
2. Error: formattable (#785) (@test-tribble.R#180) 



Two new test dependencies were introduced in version 3.0.3 by upstream: lubridate and formattable. lubridate is available in the archive but formattable is not AFAICS. In order to fix this issue and make the package migrate to testing I am attaching a debdiff where I added r-cran-lubridate to d/t/control and also created a patch to remove the formattable test (this patch should be removed when formattable lands in the archive).

Thanks in advance for considering the patch!

-- 
Lucas Kanashiro

-------------- next part --------------
diff --color -Nru r-cran-tibble-3.0.3/debian/changelog r-cran-tibble-3.0.3.new/debian/changelog
--- r-cran-tibble-3.0.3/debian/changelog	2020-07-16 04:45:01.000000000 -0300
+++ r-cran-tibble-3.0.3.new/debian/changelog	2020-09-09 17:48:43.722431124 -0300
@@ -1,3 +1,12 @@
+r-cran-tibble (3.0.3-2) UNRELEASED; urgency=medium
+
+  * Fix autopkgtest failure.
+    - d/t/control: add dependency on r-cran-lubridate.
+    - d/p/disable-formattable-test.patch: formattable is a new test dependency
+      and it is not available in the archive.
+
+ -- Lucas Kanashiro <kanashiro at debian.org>  Wed, 09 Sep 2020 16:54:54 -0300
+
 r-cran-tibble (3.0.3-1) unstable; urgency=medium
 
   * Team upload.
diff --color -Nru r-cran-tibble-3.0.3/debian/patches/disable-formattable-test.patch r-cran-tibble-3.0.3.new/debian/patches/disable-formattable-test.patch
--- r-cran-tibble-3.0.3/debian/patches/disable-formattable-test.patch	1969-12-31 21:00:00.000000000 -0300
+++ r-cran-tibble-3.0.3.new/debian/patches/disable-formattable-test.patch	2020-09-09 17:47:55.866285229 -0300
@@ -0,0 +1,23 @@
+Description: Disable formattable test
+ formattable is a new test dependency and it is not available in the archive
+ yet. Please enable this test again as soon as it is available.
+Author: Lucas Kanashiro <lucas.kanashiro at canonical.com>
+Forwarded: not-needed
+Last-Updated: 2020-09-09
+
+--- a/tests/testthat/test-tribble.R
++++ b/tests/testthat/test-tribble.R
+@@ -176,13 +176,6 @@
+   )
+ })
+ 
+-test_that("formattable (#785)", {
+-  expect_equal(
+-    tribble(~ x, formattable::formattable(1.0, 1), formattable::formattable(2.0, 1)),
+-    tibble(x = formattable::formattable(1:2 + 0, 1))
+-  )
+-})
+-
+ # ---- frame_matrix() ----
+ 
+ test_that("frame_matrix constructs a matrix as expected", {
diff --color -Nru r-cran-tibble-3.0.3/debian/patches/series r-cran-tibble-3.0.3.new/debian/patches/series
--- r-cran-tibble-3.0.3/debian/patches/series	1969-12-31 21:00:00.000000000 -0300
+++ r-cran-tibble-3.0.3.new/debian/patches/series	2020-09-09 17:44:13.393603168 -0300
@@ -0,0 +1 @@
+disable-formattable-test.patch
diff --color -Nru r-cran-tibble-3.0.3/debian/tests/control r-cran-tibble-3.0.3.new/debian/tests/control
--- r-cran-tibble-3.0.3/debian/tests/control	2020-07-16 04:45:01.000000000 -0300
+++ r-cran-tibble-3.0.3.new/debian/tests/control	2020-09-09 17:08:29.494825526 -0300
@@ -1,3 +1,3 @@
 Tests: run-unit-test
-Depends: @, r-cran-testthat, r-cran-data.table, r-cran-rsqlite, r-cran-knitr, r-cran-dplyr, r-cran-withr, r-cran-mockr
+Depends: @, r-cran-testthat, r-cran-data.table, r-cran-rsqlite, r-cran-knitr, r-cran-dplyr, r-cran-withr, r-cran-mockr, r-cran-lubridate
 Restrictions: allow-stderr