[R-pkg-team] Bug#1028130: r-cran-hunspell: please don't use internal en_US and en_GB dictionaries

[Rene Engelhard]

Hi,

Am 09.01.23 um 21:18 schrieb Andreas Tille:
> Control: tags -1 help

Erm, no? I think you mean #1028124, not this one (#1028130)?

> I pushed some changes to git[1] that should fix this bug.
You only applied half of the patch in #1028124 so of course it breaks.
> Unfortunately the package does not build any more (even without my
> changes)[2] due to
>
> Error: package or namespace load failed for 'hunspell' in dyn.load(file, DLLpath = DLLpath, ...):
>   unable to load shared object '/builds/r-pkg-team/r-cran-hunspell/debian/output/source_dir/debian/r-cran-hunspell/usr/lib/R/site-library/00LOCK-source_dir/00new/hunspell/libs/hunspell.so':
>    /builds/r-pkg-team/r-cran-hunspell/debian/output/source_dir/debian/r-cran-hunspell/usr/lib/R/site-library/00LOCK-source_dir/00new/hunspell/libs/hunspell.so: undefined symbol: _Z6u8_u16RSt6vectorI6w_charSaIS0_EERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEb
> Error: loading failed
> Execution halted

Of course that now happens if you build against sid.

The private headers now are for 1.7.2 - which as of now is in 
experimental and thus you need to build against 1.7.2 (and probably have 
a updated runtime dependency.)

Which is what my patch does in addition to the headers only. You just 
applied the header change in 
https://salsa.debian.org/r-pkg-team/r-cran-hunspell/-/commit/ae8796cc2e2b72372b55cf40ce35a15bf00ae2d8, 
neither the build-dependency nor the runtime dependency. Do that and 
build against hunspell 1.7.2 and it will build.


The problem per se is that you copy private stuff over.


No one said 1.7.2 was in sid (actually if it was it would have been 
serious instead of important)


(And also see 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028124#24 which I 
especially wrote to make the RT and you aware that 1.7.2 will not be 
there soonish as hunspell-ko still breaks with 1.7.2).


Regards,

Rene