[R-pkg-team] Bug#1071348: r-bioc-s4arrays: FTBFS: array_selection.c:352:17: error: format not a string literal and no format arguments

[Santiago Vila]

Package: src:r-bioc-s4arrays
Version: 1.2.0+dfsg-1
Severity: serious
Tags: ftbfs

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

--------------------------------------------------------------------------------
[...]
  debian/rules binary
dh binary --buildsystem R
    dh_update_autotools_config -O--buildsystem=R
    dh_autoreconf -O--buildsystem=R
    dh_auto_configure -O--buildsystem=R
    dh_auto_build -O--buildsystem=R
    dh_auto_test -O--buildsystem=R
    create-stamp debian/debhelper-build-stamp
    dh_testroot -O--buildsystem=R
    dh_prep -O--buildsystem=R
    dh_auto_install --destdir=debian/r-bioc-s4arrays/ -O--buildsystem=R
I: R Package: S4Arrays Version: 1.2.0
I: Building using R version 4.4.0-2
I: R API version: r-api-4.0
I: Using built-time from d/changelog: Thu, 30 Nov 2023 00:16:36 +0000
	mkdir -p /<<BUILDDIR>>/r-bioc-s4arrays-1.2.0\+dfsg/debian/r-bioc-s4arrays/usr/lib/R/site-library
	R CMD INSTALL -l /<<BUILDDIR>>/r-bioc-s4arrays-1.2.0\+dfsg/debian/r-bioc-s4arrays/usr/lib/R/site-library --clean . "--built-timestamp='Thu, 30 Nov 2023 00:16:36 +0000'"
* installing *source* package ‘S4Arrays’ ...
** using staged installation
** libs
using C compiler: ‘gcc (Debian 13.2.0-25) 13.2.0’
make[1]: Entering directory '/<<PKGBUILDDIR>>/src'
gcc -I"/usr/share/R/include" -DNDEBUG  -I'/usr/lib/R/site-library/S4Vectors/include'     -fpic  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/r-base-4.4.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c R_init_S4Arrays.c -o R_init_S4Arrays.o
gcc -I"/usr/share/R/include" -DNDEBUG  -I'/usr/lib/R/site-library/S4Vectors/include'     -fpic  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/r-base-4.4.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c S4Vectors_stubs.c -o S4Vectors_stubs.o
gcc -I"/usr/share/R/include" -DNDEBUG  -I'/usr/lib/R/site-library/S4Vectors/include'     -fpic  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/r-base-4.4.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c abind.c -o abind.o
gcc -I"/usr/share/R/include" -DNDEBUG  -I'/usr/lib/R/site-library/S4Vectors/include'     -fpic  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/r-base-4.4.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c array_selection.c -o array_selection.o
array_selection.c: In function ‘C_Lindex2Mindex’:
array_selection.c:352:17: error: format not a string literal and no format arguments [-Werror=format-security]
   352 |                 error(errmsg_buf());
       |                 ^~~~~
array_selection.c: In function ‘C_Mindex2Lindex’:
array_selection.c:416:17: error: format not a string literal and no format arguments [-Werror=format-security]
   416 |                 error(errmsg_buf());
       |                 ^~~~~
cc1: some warnings being treated as errors
make[1]: *** [/usr/lib/R/etc/Makeconf:195: array_selection.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: Entering directory '/<<PKGBUILDDIR>>/src'
make[1]: Leaving directory '/<<PKGBUILDDIR>>/src'
ERROR: compilation failed for package ‘S4Arrays’
* removing ‘/<<PKGBUILDDIR>>/debian/r-bioc-s4arrays/usr/lib/R/site-library/S4Arrays’
dh_auto_install: error: R CMD INSTALL -l /<<BUILDDIR>>/r-bioc-s4arrays-1.2.0\+dfsg/debian/r-bioc-s4arrays/usr/lib/R/site-library --clean . "--built-timestamp='Thu, 30 Nov 2023 00:16:36 +0000'" returned exit code 1
make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202405/

About the archive rebuild: The build was made on virtual machines
of type m6a.large and r6a.large from AWS, using sbuild and a
reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Thanks.